Fix participant saves and link calendar attendees to meeting notes#544
Merged
gabrielste1n merged 3 commits intomainfrom Apr 3, 2026
Merged
Fix participant saves and link calendar attendees to meeting notes#544gabrielste1n merged 3 commits intomainfrom
gabrielste1n merged 3 commits intomainfrom
Conversation
Extract attendee data from Google Calendar API and store as JSON on calendar_events. Auto-link notes to calendar events and populate participants when meeting detection creates a note. Add contacts table as a materialized index for cross-note autocomplete. New Granola-style attendee chip + popover in the note metadata bar with domain grouping, Gravatar avatars with initial-circle fallback, search/ add/remove participants, and contacts autocomplete via IPC. Popover uses new Radix Popover primitive (shadcn/ui pattern). Translations added for all 10 locales.
Add note.id to parsedParticipants memo dependency so it recomputes when switching notes even when both have null participants. Fix Gravatar hash effect dependency to use localParticipants instead of prop. Remove redundant JSX comments.
…cipant saves The meeting detection engine updated notes with calendar attendees directly via databaseManager.updateNote() but never broadcast note-updated, so the store kept the bare note without participants. Manual adds then overwrote calendar attendees in the DB. - Broadcast note-updated after setting calendar_event_id/participants - NoteParticipants now owns its save via stable noteId-based callback instead of receiving an unstable inline onUpdate from NoteEditor - Extract ParticipantAvatar component for cleaner avatar rendering
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
calendar_event_idandparticipantsbut never broadcastingnote-updated, so the UI showed 0 attendees until navigation. Manual adds then overwrote the calendar attendees in the DB.NoteParticipantsnow owns its own save via a stablenoteId-baseduseCallbackinstead of receiving an unstable inlineonUpdateclosure fromNoteEditorthat was recreated every render.ParticipantAvatarcomponent — pulled the inline Gravatar + colored-initials rendering into a typed component, applied to both the participant list and the contact suggestions.Changes
meetingDetectionEngine.jsnote-updatedafter setting calendar attendees on a new meeting noteNoteParticipants.tsxnoteIdprop, ownssaveParticipantscallback, extractsParticipantAvatarNoteEditor.tsxnoteIdinstead of inlineonUpdatecallbackTest plan