Skip to content

docs(account/AccountERC7579): clarify ERC-1271 behavior and no native fallback #5925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: typo-fixes
Choose a base branch
from
+12 −2
Open

docs(account/AccountERC7579): clarify ERC-1271 behavior and no native fallback #5925

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2ee7d1
docs(account/AccountERC7579): clarify ERC-1271 behavior and no native…
Snezhkko Sep 8, 2025
518a78f
Update draft-AccountERC7579.sol
Snezhkko Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions contracts/account/extensions/draft-AccountERC7579.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,13 @@ abstract contract AccountERC7579 is Account, IERC1271, IERC7579Execution, IERC75
}

/**
* @dev Implement ERC-1271 through IERC7579Validator modules. If module based validation fails, fallback to
* "native" validation by the abstract signer.
* @dev Implements ERC-1271 by delegating validation to installed {IERC7579Validator} modules via
* {IERC7579Validator-isValidSignatureWithSender}. If no installed module validates the signature, this
* function returns `0xffffffff`.
*
* This extension does not perform native/raw signature validation by default. Developers who require
* native/raw validation should either override this function to include it or compose with other
* extensions (e.g. {ERC7739}) and resolve multiple inheritance explicitly.
*
* NOTE: when combined with {ERC7739}, resolution ordering may have an impact ({ERC7739} does not call super).
* Manual resolution might be necessary.
Expand All @@ -200,6 +205,11 @@ abstract contract AccountERC7579 is Account, IERC1271, IERC7579Execution, IERC75
* if the module specified by the first 20 bytes of the nonce key is installed. Falls back to
* {Account-_validateUserOp} otherwise.
*
* Note: if no installed validation module is extracted from the user operation, this function
* defers to {Account-_validateUserOp}, which performs a {_rawSignatureValidation} check. This contract
* overrides {_rawSignatureValidation} to always return `false`. Projects that require native/raw
* validation should override {_rawSignatureValidation} or compose with another extension that provides it.
*
* See {_extractUserOpValidator} for the module extraction logic.
*/
function _validateUserOp(
Expand Down
Loading