-
Notifications
You must be signed in to change notification settings - Fork 0
chore: Add additional checks #83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,59 @@ | ||||||
| name: 'CLA Assistant' | ||||||
| on: | ||||||
| issue_comment: | ||||||
| types: [created] | ||||||
| pull_request_target: | ||||||
| types: [opened, closed, synchronize] | ||||||
|
|
||||||
| permissions: | ||||||
| actions: write | ||||||
| contents: write | ||||||
| pull-requests: write | ||||||
| statuses: write | ||||||
| checks: write | ||||||
| issues: write | ||||||
|
|
||||||
| jobs: | ||||||
| CLAAssistant: | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - name: Harden the runner (Audit all outbound calls) | ||||||
| uses: step-security/harden-runner@ec9f2d5744a09debf3a187a3f4f675c53b671911 # v2.13.0 | ||||||
|
||||||
| uses: step-security/harden-runner@ec9f2d5744a09debf3a187a3f4f675c53b671911 # v2.13.0 | |
| uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1 |
Copilot
AI
Feb 19, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checkout action version comment indicates v5.0.0, but the existing ci.yml uses the same commit hash (08c6903cd8c0fde910a37f88322edcfb5dd907a8) with version v4.5.4. There's a discrepancy in the version tag. Please verify the correct version for this commit hash and ensure consistency across all workflows.
| uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 #v5.0.0 | |
| uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v4.5.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multi-line file content may break GITHUB_OUTPUT handling.
If allowlist.txt contains multiple lines or special characters, the current approach will only capture the first line or cause parsing issues. Multi-line values in GITHUB_OUTPUT require heredoc syntax.
🔧 Proposed fix for multi-line support
- name: Read Allowlist File
id: read_allowlist
run: |
- ALLOWLIST=$(cat allowlist.txt)
- echo "allowlist=$ALLOWLIST" >> $GITHUB_OUTPUT
+ {
+ echo 'allowlist<<EOF'
+ cat allowlist.txt
+ echo 'EOF'
+ } >> $GITHUB_OUTPUT🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/cla.yml around lines 36 - 38, The current step reads
allowlist.txt into ALLOWLIST and writes it to GITHUB_OUTPUT with a single-line
echo which breaks multi-line or special-character content; change the write to
use the GitHub Actions multi-line output/heredoc pattern so the "allowlist"
output receives the full ALLOWLIST content (preserving newlines and special
chars) instead of a single-line echo to GITHUB_OUTPUT.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,56 @@ | ||||||
| name: 'CodeQL Advanced' | ||||||
|
|
||||||
| on: | ||||||
| push: | ||||||
| branches: ['main', 'release-v*'] | ||||||
| pull_request: | ||||||
| branches: ['main'] | ||||||
| schedule: | ||||||
| - cron: '40 12 * * 3' | ||||||
|
|
||||||
| permissions: | ||||||
| contents: read | ||||||
|
|
||||||
| jobs: | ||||||
| analyze: | ||||||
| name: Analyze (${{ matrix.language }}) | ||||||
| runs-on: ${{ (matrix.language == 'swift' && 'macos-latest') || 'ubuntu-latest' }} | ||||||
| permissions: | ||||||
| # required for all workflows | ||||||
| security-events: write | ||||||
|
|
||||||
| # required to fetch internal or private CodeQL packs | ||||||
| actions: read | ||||||
|
|
||||||
| # only required for workflows in private repositories | ||||||
| # actions: read | ||||||
| # contents: read | ||||||
|
|
||||||
| strategy: | ||||||
| fail-fast: false | ||||||
| matrix: | ||||||
| include: | ||||||
| - language: actions | ||||||
| build-mode: none | ||||||
| - language: javascript-typescript | ||||||
| build-mode: none | ||||||
|
|
||||||
| steps: | ||||||
| - name: Harden the runner (Audit all outbound calls) | ||||||
| uses: step-security/harden-runner@ec9f2d5744a09debf3a187a3f4f675c53b671911 # v2.13.0 | ||||||
|
||||||
| uses: step-security/harden-runner@ec9f2d5744a09debf3a187a3f4f675c53b671911 # v2.13.0 | |
| uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1 |
Copilot
AI
Feb 19, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checkout action version comment indicates v5.0.0, but the existing ci.yml uses the same commit hash (08c6903cd8c0fde910a37f88322edcfb5dd907a8) with version v4.5.4. There's a discrepancy in the version tag. Please verify the correct version for this commit hash and ensure consistency across all workflows.
| uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | |
| uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v4.5.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify that the SHA hashes match the claimed action versions
echo "=== Checking actions/checkout ==="
echo "Claimed: v5.0.0, SHA: 08c6903cd8c0fde910a37f88322edcfb5dd907a8"
# Get the actual SHA for v5.0.0 tag
curl -s "https://api.github.com/repos/actions/checkout/git/ref/tags/v5.0.0" | jq -r '.object.sha // "tag not found"'
echo ""
echo "=== Checking github/codeql-action ==="
echo "Claimed: v3.30.6, SHA: 64d10c13136e1c5bce3e5fbde8d4906eeaafc885"
curl -s "https://api.github.com/repos/github/codeql-action/git/ref/tags/v3.30.6" | jq -r '.object.sha // "tag not found"'
echo ""
echo "=== Checking step-security/harden-runner ==="
echo "Claimed: v2.13.0, SHA: ec9f2d5744a09debf3a187a3f4f675c53b671911"
curl -s "https://api.github.com/repos/step-security/harden-runner/git/ref/tags/v2.13.0" | jq -r '.object.sha // "tag not found"'Repository: OpenZeppelin/relayer-plugin-channels
Length of output: 512
Fix incorrect version comment for github/codeql-action SHA.
The pinned action SHA 64d10c13136e1c5bce3e5fbde8d4906eeaafc885 does not match v3.30.6 (which actually resolves to 4110a988ca85d436f1ad69dd90aed6222a6ac39e). Verify which version is intended and update the comment to reflect the actual version of the pinned SHA, or update the SHA if v3.30.6 is the intended version.
Actions/checkout v5.0.0 and step-security/harden-runner v2.13.0 have correct SHA/version pairs.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/codeql.yml around lines 40 - 55, The version comment for
the github/codeql-action SHA is incorrect: the uses entries for
github/codeql-action/init and github/codeql-action/analyze reference SHA
64d10c13136e1c5bce3e5fbde8d4906eeaafc885 but are labeled v3.30.6; verify which
you intend and either (A) update the inline comment to the actual release that
corresponds to 64d10c13, or (B) replace the SHA with the canonical SHA for
v3.30.6 (e.g., 4110a988ca85d436f1ad69dd90aed6222a6ac39e) so the comment and SHA
match; apply the same fix to both github/codeql-action/init and
github/codeql-action/analyze entries.
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,28 @@ | ||||||
| # Dependency Review Action | ||||||
| # | ||||||
| # This Action will scan dependency manifest files that change as part of a Pull Request, | ||||||
| # surfacing known-vulnerable versions of the packages declared or updated in the PR. | ||||||
| # Once installed, if the workflow run is marked as required, | ||||||
| # PRs introducing known-vulnerable packages will be blocked from merging. | ||||||
| # | ||||||
| # Source repository: https://github.com/actions/dependency-review-action | ||||||
|
|
||||||
| name: 'Dependency Review' | ||||||
| on: [pull_request] | ||||||
|
|
||||||
| permissions: | ||||||
| contents: read | ||||||
|
|
||||||
| jobs: | ||||||
| dependency-review: | ||||||
| runs-on: ubuntu-latest | ||||||
| steps: | ||||||
| - name: Harden Runner | ||||||
| uses: step-security/harden-runner@ec9f2d5744a09debf3a187a3f4f675c53b671911 # v2.13.0 | ||||||
|
||||||
| uses: step-security/harden-runner@ec9f2d5744a09debf3a187a3f4f675c53b671911 # v2.13.0 | |
| uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1 |
Copilot
AI
Feb 19, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checkout action version comment indicates v5.0.0, but the existing ci.yml uses the same commit hash (08c6903cd8c0fde910a37f88322edcfb5dd907a8) with version v4.5.4. There's a discrepancy in the version tag. Please verify the correct version for this commit hash and ensure consistency across all workflows.
| uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | |
| uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v4.5.4 |
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,61 @@ | ||||||||||||||
| # This workflow uses actions that are not certified by GitHub. They are provided | ||||||||||||||
| # by a third-party and are governed by separate terms of service, privacy | ||||||||||||||
| # policy, and support documentation. | ||||||||||||||
|
|
||||||||||||||
| name: Scorecard supply-chain security | ||||||||||||||
| on: | ||||||||||||||
| # To guarantee Maintained check is occasionally updated. See | ||||||||||||||
| # https://github.com/ossf/scorecard/blob/main/docs/checks.md#maintained | ||||||||||||||
| schedule: | ||||||||||||||
| - cron: '35 1 * * 6' | ||||||||||||||
| push: | ||||||||||||||
| branches: ['main'] | ||||||||||||||
|
|
||||||||||||||
| # Declare default permissions as read only. | ||||||||||||||
| permissions: read-all | ||||||||||||||
|
|
||||||||||||||
| jobs: | ||||||||||||||
| analysis: | ||||||||||||||
| name: Scorecard analysis | ||||||||||||||
| runs-on: ubuntu-latest | ||||||||||||||
| permissions: | ||||||||||||||
| # Needed to upload the results to code-scanning dashboard. | ||||||||||||||
| security-events: write | ||||||||||||||
| # Needed to publish results and get a badge (see publish_results below). | ||||||||||||||
| id-token: write | ||||||||||||||
| # Comment/renmove the permissions below if installing in a public repository. | ||||||||||||||
|
||||||||||||||
| # Comment/renmove the permissions below if installing in a public repository. | |
| # Comment/remove the permissions below if installing in a public repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix typo: "renmove" → "remove".
✏️ Proposed fix
- # Comment/renmove the permissions below if installing in a public repository.
+ # Comment/remove the permissions below if installing in a public repository.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| # Comment/renmove the permissions below if installing in a public repository. | |
| # Comment/remove the permissions below if installing in a public repository. |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/scorecard.yml at line 26, Update the comment string in the
GitHub Actions workflow where it reads "Comment/renmove the permissions below if
installing in a public repository." to correct the typo by replacing "renmove"
with "remove" so the comment reads "Comment/remove the permissions below if
installing in a public repository."; locate and edit that exact comment line in
scorecard.yml.
Copilot
AI
Feb 19, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The harden-runner action version differs from the existing workflow. The ci.yml uses v2.10.1 (commit 91182cccc01eb5e619899d80e4e971d6181294a7), but this workflow uses v2.13.0 (commit ec9f2d5744a09debf3a187a3f4f675c53b671911). For consistency and to ensure all workflows use the same security baseline, consider standardizing on the same version across all workflows. If v2.13.0 is the preferred version, the existing ci.yml should also be updated.
| uses: step-security/harden-runner@ec9f2d5744a09debf3a187a3f4f675c53b671911 # v2.13.0 | |
| uses: step-security/harden-runner@91182cccc01eb5e619899d80e4e971d6181294a7 # v2.10.1 |
Copilot
AI
Feb 19, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checkout action version comment indicates v5.0.0, but the existing ci.yml uses the same commit hash (08c6903cd8c0fde910a37f88322edcfb5dd907a8) with version v4.5.4. There's a discrepancy in the version tag. Please verify the correct version for this commit hash and ensure consistency across all workflows.
| uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | |
| uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v4.5.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
echo "=== Checking ossf/scorecard-action ==="
echo "Claimed: v2.4.2, SHA: 05b42c624433fc40578a4040d5cf5e36ddca8cde"
curl -s "https://api.github.com/repos/ossf/scorecard-action/git/ref/tags/v2.4.2" | jq -r '.object.sha // "tag not found"'
echo ""
echo "=== Checking actions/upload-artifact ==="
echo "Claimed: v4.6.2, SHA: ea165f8d65b6e75b540449e92b4886f43607fa02"
curl -s "https://api.github.com/repos/actions/upload-artifact/git/ref/tags/v4.6.2" | jq -r '.object.sha // "tag not found"'Repository: OpenZeppelin/relayer-plugin-channels
Length of output: 368
Update scorecard-action SHA to match v2.4.2.
The claimed SHA 05b42c624433fc40578a4040d5cf5e36ddca8cde for ossf/scorecard-action@v2.4.2 is incorrect. The actual SHA for v2.4.2 is f2ea147fec3c2f0d459703eba7405b5e9bcd8c8f. Update line 42 to use the correct commit hash.
The upload-artifact SHA is correct and requires no changes.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/scorecard.yml around lines 42 - 55, Replace the incorrect
commit SHA for the ossf/scorecard-action usage: locate the uses entry that reads
"uses: ossf/scorecard-action@05b42c624433fc40578a4040d5cf5e36ddca8cde" (the one
tied to v2.4.2) and update the commit hash to the correct SHA
"f2ea147fec3c2f0d459703eba7405b5e9bcd8c8f"; do not modify the upload-artifact
uses entry.
Copilot
AI
Feb 19, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version comment indicates v2.3.5, but this appears to be incorrect. The codeql.yml file in this PR uses the same commit hash (64d10c13136e1c5bce3e5fbde8d4906eeaafc885) with version v3.30.6. Please update the version comment to match the actual version.
| uses: github/codeql-action/upload-sarif@64d10c13136e1c5bce3e5fbde8d4906eeaafc885 # v2.3.5 | |
| uses: github/codeql-action/upload-sarif@64d10c13136e1c5bce3e5fbde8d4906eeaafc885 # v3.30.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version comment mismatch: says v2.3.5 but SHA is for v3.30.6.
The SHA 64d10c13136e1c5bce3e5fbde8d4906eeaafc885 is the same one used in codeql.yml where it's labeled as v3.30.6. The comment here says v2.3.5 which is inconsistent and misleading.
✏️ Proposed fix
- uses: github/codeql-action/upload-sarif@64d10c13136e1c5bce3e5fbde8d4906eeaafc885 # v2.3.5
+ uses: github/codeql-action/upload-sarif@64d10c13136e1c5bce3e5fbde8d4906eeaafc885 # v3.30.6📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| - name: 'Upload to code-scanning' | |
| uses: github/codeql-action/upload-sarif@64d10c13136e1c5bce3e5fbde8d4906eeaafc885 # v2.3.5 | |
| - name: 'Upload to code-scanning' | |
| uses: github/codeql-action/upload-sarif@64d10c13136e1c5bce3e5fbde8d4906eeaafc885 # v3.30.6 |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In @.github/workflows/scorecard.yml around lines 58 - 59, The version comment
next to the GitHub Action step named 'Upload to code-scanning' is inconsistent
with the SHA used; update the inline comment after uses:
github/codeql-action/upload-sarif@64d10c13136e1c5bce3e5fbde8d4906eeaafc885 to
match the actual action version (change `v2.3.5` to `v3.30.6`) so the label
accurately reflects the SHA referenced by the upload-sarif action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow uses pull_request_target trigger with broad write permissions (actions, contents, pull-requests, statuses, checks, issues). While this is necessary for the CLA Assistant action to function, pull_request_target runs in the context of the base repository and has access to secrets, which could be a security risk if the workflow checks out or executes code from the PR. However, this workflow only checks out the private cla-sigs repository and does not check out or execute any code from the pull request itself, so this appears to be safe. Consider adding a comment explaining this security consideration for future maintainers.