Open
Conversation
rocktavious
reviewed
Nov 19, 2024
Comment on lines
+23
to
+24
| DEPLOYER_ID="$(Build.QueuedById)" | ||
| DEPLOYER_ID="${DEPLOYER_ID:-$(Build.QueuedById)}" |
Contributor
There was a problem hiding this comment.
Suggested change
| DEPLOYER_ID="$(Build.QueuedById)" | |
| DEPLOYER_ID="${DEPLOYER_ID:-$(Build.QueuedById)}" | |
| DEPLOYER_ID="$(Build.QueuedById)" |
rocktavious
reviewed
Nov 19, 2024
| DEPLOYER_NAME="$(Build.RequestedFor)" | ||
| DEPLOY_NUMBER="$(Build.BuildNumber)" | ||
| DEPLOY_URL="$(Build.BuildUri)" | ||
| VERSION="${VERSION:-$(git rev-parse --short HEAD)}" # Default to the current git commit hash |
Contributor
There was a problem hiding this comment.
Suggested change
| VERSION="${VERSION:-$(git rev-parse --short HEAD)}" # Default to the current git commit hash | |
| VERSION="$(git rev-parse --short HEAD)" |
rocktavious
reviewed
Nov 19, 2024
| DEPLOY_NUMBER="$(Build.BuildNumber)" | ||
| DEPLOY_URL="$(Build.BuildUri)" | ||
| VERSION="${VERSION:-$(git rev-parse --short HEAD)}" # Default to the current git commit hash | ||
| DESCRIPTION="${DESCRIPTION:-"Deployed by CI Pipeline: Deploy #${DEPLOY_NUMBER}"}" |
Contributor
There was a problem hiding this comment.
I don't think this works in AzureDevOps
rocktavious
reviewed
Nov 19, 2024
|
|
||
| # Payload for the OpsLevel API | ||
| data="{ | ||
| \"dedup_id\": \"$(uuidgen)\", |
Contributor
There was a problem hiding this comment.
This shouldn't be a unique ID per invocation - it should be the Build.BuildNumber or some sort of "pipeline" number. The purpose of the dedup_id is incase you need to retry the pipeline its considered the same event incase we received 2
rocktavious
reviewed
Nov 19, 2024
Comment on lines
+31
to
+39
| COMMIT_SHA="${COMMIT_SHA:-$(git rev-parse HEAD)}" | ||
| COMMIT_MESSAGE="${COMMIT_MESSAGE:-$(git log -1 --pretty=%B)}" | ||
| COMMIT_BRANCH="${COMMIT_BRANCH:-$(git rev-parse --abbrev-ref HEAD)}" | ||
| COMMIT_DATE="${COMMIT_DATE:-$(git show --no-patch --format='%cd')}" | ||
| COMMITTER_NAME="${COMMITTER_NAME:-$(git show --no-patch --format='%cn')}" | ||
| COMMITTER_EMAIL="${COMMITTER_EMAIL:-$(git show --no-patch --format='%ce')}" | ||
| AUTHOR_NAME="${AUTHOR_NAME:-$(git show --no-patch --format='%an')}" | ||
| AUTHOR_EMAIL="${AUTHOR_EMAIL:-$(git show --no-patch --format='%ae')}" | ||
| AUTHORING_DATE="${AUTHORING_DATE:-$(git show --no-patch --format='%ad')}" |
Contributor
There was a problem hiding this comment.
All of these have input environment variables - my understanding is they will always be blank.
So 2 things
- Should we expose all (or some) of these as parameters?
- Should we remove the variables and just run the git commands.
rocktavious
reviewed
Nov 19, 2024
Comment on lines
+2
to
+11
| - name: 'env' | ||
| default: 'Production' | ||
| type: string | ||
| - name: 'integrationId' | ||
| type: string | ||
| - name: 'serviceAlias' | ||
| type: string | ||
| - name: 'apiUrl' | ||
| default: 'https://app.opslevel.com/' | ||
| type: string |
Contributor
There was a problem hiding this comment.
Alphabetize by parameters name
Suggested change
| - name: 'env' | |
| default: 'Production' | |
| type: string | |
| - name: 'integrationId' | |
| type: string | |
| - name: 'serviceAlias' | |
| type: string | |
| - name: 'apiUrl' | |
| default: 'https://app.opslevel.com/' | |
| type: string | |
| - name: 'apiUrl' | |
| default: 'https://app.opslevel.com/' | |
| type: string | |
| - name: 'env' | |
| default: 'Production' | |
| type: string | |
| - name: 'integrationId' | |
| type: string | |
| - name: 'serviceAlias' | |
| type: string |
rocktavious
requested changes
Nov 19, 2024
Contributor
rocktavious
left a comment
rocktavious
left a comment
There was a problem hiding this comment.
There are a few "polish" things that need to be taken care of
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.