Expand version pins to support sidekiq 8.0#16
Closed
bmulholland wants to merge 1 commit intoOpsLevel:masterfrom
Closed
Expand version pins to support sidekiq 8.0#16bmulholland wants to merge 1 commit intoOpsLevel:masterfrom
bmulholland wants to merge 1 commit intoOpsLevel:masterfrom
Conversation
|
|
|
thanks for submitting this PR (and sorry for taking so long to reply)! can you please accept the Contributor License Agreement we can merge this |
|
closing in favour of #17 where we added some tests as well. thanks again for submitting this PR! |
Author
|
Apologies for the slow response. Your PR is better anyway, so I'm happy to have this closed. Thanks again for publishing your work, so we can use it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if you all want update PRs, considering issues are closed. Still, this is currently the most updated version of simplekiq and we've been using it -- thank you -- so this is a small way to give back.