This repository was archived by the owner on Sep 28, 2023. It is now read-only.
update scroll-top.component.ts #218
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add scroll behavior to the window.scrollTo(), by default the behavior is auto, giving an extra option for smooth-scroll would be nice.
Lausselloic
suggested changes
Oct 26, 2020
|
|
||
| public ScrollToTop() { | ||
| window.scrollTo(0, 0); | ||
| window.scrollTo(0, 0, behavior); |
Member
There was a problem hiding this comment.
looks like it's not the way to pass behavior option to scrollTo function
Maybe try : scrollTo({ top:0, left:0, behavior: this.behavior })
Member
There was a problem hiding this comment.
and it's not IE compliant, and iOS doesn't have smooth effect https://developer.mozilla.org/fr/docs/Web/API/ScrollToOptions
Need to check if it comply with accessibility rules too
Author
There was a problem hiding this comment.
That is why i closed this MR, missing the This.
Member
There was a problem hiding this comment.
You can update this PR and fix errors by pushing more commits to your branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a scroll behavior to the window.scrollTo(), by default the behavior is auto, giving an extra option for smooth-scroll would be nice.