-
Notifications
You must be signed in to change notification settings - Fork 43
Update pom.xml to use maven.compiler.release #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pom.xml to use maven.compiler.release #238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Around line ~415 the build -> pluginManagement -> plugins -> plugin defintion for the maven-compiler-plugin refrences the removed source/target properties. This was done in a past Maven version where - for reasons unknown - the properties alone did not work. These references should be removed as well as the properties themselves. Otherwise I have checked and verified that the class file version remains unaffected by this change and still marks compiled code as Java 8 compatible (class file version 52).
AFaust
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change in pom.xml requested to remove reference to the removed properties.
|
@AFaust I changed it to adress JDK8 as well as JDK9 and above regarding to |
| <configuration> | ||
| <source>${maven.compiler.target}</source> | ||
| <target>${maven.compiler.target}</target> | ||
| <release>${java.version}</release> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the maven.compiler.release property here? Or delete that in the properties section - either way would be fine.
* changed to <maven.compiler.release> * updated maven.compiler.version to 3.14.0
* changed configuration for maven compiler for the use of jdk8 (added source and target for backward compatability)
3949bfd to
e34e26f
Compare
I rebased the PR and applied requested change myself.
CHECKLIST
We will not consider a PR until the following items are checked off--thank you!
CONVINCING DESCRIPTION
#237
RELATED INFORMATION
https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html
Fixes #
BE WARNED
When we decline or close your PR. You are encouraged to address the concerns outlined in the
PR and then re-submit it. We want contributions. We also need for them to be of high quality
and high value and to not take undue resources away from the features and enhancements the
core team is working on. Thanks for understanding!