Skip to content

Conversation

@aitseitz
Copy link
Contributor

  • changed to <maven.compiler.release>
  • updated maven.compiler.version to 3.14.0

CHECKLIST

We will not consider a PR until the following items are checked off--thank you!

  • [ x] There aren't existing pull requests attempting to address the issue mentioned here
  • [ x] Submission developed in a feature branch--not master

CONVINCING DESCRIPTION

#237

RELATED INFORMATION

https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html

Fixes #

BE WARNED

  • If any of the checklist items are missed, incomplete or invalid we will not accept the PR
  • If you are not responsive to feedback on your PR we will not accept the PR
  • If we do not accept your PR we will provide feedback on the PR indicating why
  • After some time, we will close PRs that have not been accepted

When we decline or close your PR. You are encouraged to address the concerns outlined in the
PR and then re-submit it. We want contributions. We also need for them to be of high quality
and high value and to not take undue resources away from the features and enhancements the
core team is working on. Thanks for understanding!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Around line ~415 the build -> pluginManagement -> plugins -> plugin defintion for the maven-compiler-plugin refrences the removed source/target properties. This was done in a past Maven version where - for reasons unknown - the properties alone did not work. These references should be removed as well as the properties themselves. Otherwise I have checked and verified that the class file version remains unaffected by this change and still marks compiled code as Java 8 compatible (class file version 52).

AFaust
AFaust previously requested changes Mar 20, 2025
Copy link
Contributor

@AFaust AFaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change in pom.xml requested to remove reference to the removed properties.

@aitseitz
Copy link
Contributor Author

@AFaust
Absolutly right.

I changed it to adress JDK8 as well as JDK9 and above regarding to
https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html#usage-on-jdk-8

<configuration>
<source>${maven.compiler.target}</source>
<target>${maven.compiler.target}</target>
<release>${java.version}</release>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use the maven.compiler.release property here? Or delete that in the properties section - either way would be fine.

* changed to <maven.compiler.release>
* updated maven.compiler.version to 3.14.0
* changed configuration for maven compiler for the use of jdk8 (added source and target for backward compatability)
@AFaust AFaust force-pushed the feature/Update-pom.xml-to-user-maven.compiler.release branch from 3949bfd to e34e26f Compare August 12, 2025 10:22
@AFaust AFaust dismissed their stale review August 12, 2025 10:23

I rebased the PR and applied requested change myself.

@AFaust AFaust self-requested a review August 12, 2025 10:23
@AFaust AFaust merged commit 0e1611b into OrderOfTheBee:master Aug 12, 2025
1 check passed
@AFaust AFaust added this to the 1.2.3.1 milestone Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants