JavaScript Console/TernDef improvements #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ant base Java tern improvements - improved cutoff / hierarchy handling to avoid exposing too much of Java API - exclude exposing methods if hidden/skipped on base declaring class (unless parameter types differ via generics) - handle both is/get-style getters - handle fact that interop also allows calling getters/setters directly without using virtual properties - handle JavaString as extending from JavaScript String (tested that JS-only functions are callable on Java String too) - properly expose Java collection base interfaces - properly expose Java base map and scriptable variants (with their additional properties) - sort type definitions / member definitions in tern output for better future before/after comparison on changes) - allow more externalised configuration (forced exposure of classes, parent/prototype overrides) - use class name without package instead of simple class name, improving handling of nested classes - externalised some of the cutoff interfaces/classes as skip configuration
…erties fixes - generate action parameter tern definitions in backend web script - patch tern files (one backport + one custom exclusion of meta property '!original') - correct/extend some ScriptNode and other script API tern properties
AFaust
force-pushed
the
task/ternDefImprovements
branch
from
4a57f08 to
a8f54d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHECKLIST
We will not consider a PR until the following items are checked off--thank you!
CONVINCING DESCRIPTION
This PR groups various improvements to the tern support for JavaScript Console, which aim to improve handling of exposed script APIs as well as ensure all dynamic tern generation is done in a central place with consistent behaviour.
RELATED INFORMATION
While it is normally good practice to keep a PR scoped to an individual task, this includes multiple tasks as it became clear that development for task X may include / need to address changes for task Y which only became relevant during testing of task X, after the real change for task Y was already done and committed. To avoid excessive slice&dice with history rewrites, I tried to focus each commit on a primary task, but included those secondary changes as long as they did not end up dominating the commit.
Fixes #247
Fixes #249
Fixes #250
Fixes #251
Fixes #252
Fixes #254