Open
Conversation
Signed-off-by: Dockter <dockter@almuramc.com>
|
The real issue is that the effective scroll step as seen by user depends on the content size. In my code I'm overriding scroll step to be: @Override
public float getScrollStep() {
float contentSize = getContentHeight() - getHeight();
float scrollStep = super.getScrollStep() * 1000;
float scrollFraction = scrollStep / contentSize;
if (Float.isFinite(scrollFraction) && scrollFraction > 0) {
return scrollFraction;
}
return 0;
}So this change will actually break my code (actually, it doesn't work with latest version anyway. But it's still not a backwards compatible change) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dockter dockter@almuramc.com