More robust room assignement, gate/room volumes export for navkit #247
Conversation
Mods/Editor/Src/EditorServer.cpp
Outdated
| const std::string s_TypePropertyName = "m_eType"; | ||
| const std::string s_GlobalSizePropertyName = "m_vGlobalSize"; | ||
| //Write the BBox info for the gates | ||
| auto* s_Entity0 = p_Entity.QueryInterface<ZGateEntity>(); |
There was a problem hiding this comment.
Maybe we could rename this to something like s_Gate to make it easier to keep track of.
|
Works well in my testing for The Final Test mission. Did run into some issues with some missing room names and missing room folder names, and some missing names for gates and volume boxes |
dbierek
left a comment
dbierek
left a comment
There was a problem hiding this comment.
Looks like we may want to double check the room logic, as well as the name and tblu values for gates and volume boxes.
The tblu values aren't actually used by NavKit so we could probably just leave those blank.
This should be fixes by the latest commit, missing room names were coming from dynamic entities and the ones outside of the room system (usually in "set pieces"). Naming is now more robust too, relying on the tree hashmap when the previous one retrieving the tblu too failed. |
3 participants
-The previous FindRoomForEntity logic relied on the position of the entity to determine the room it belongs to. However, as spotted by @Notexe, this is not always reliable:
In the above screenshots, the entity gets assigned to the atrium room despite belonging to the "outside room". The new logic solves that by using the component hierarchy.
-Gates' and rooms' transforms are now exported to json too for further processing by navkit.
-The ZRoom and ZSparseBitArray edits are taken directly from @pavledev's fork, all credits to him for these.