Add romanized lrc files and WPE property to toggle between original and romanized#26
Merged
OriginalCube merged 5 commits intoOriginalCube:mainfrom Jun 13, 2025
Merged
Conversation
Owner
Owner
|
I encountered no problems during testing. I will now deploy and adjust the wallpaper engine property. |
OriginalCube
approved these changes
Jun 13, 2025
Owner
|
Verified changes on WE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure about the label "Lyrics display". Just wanted naming/variable consistency with "Title display", but open to better naming, as people may confuse it with visibility. Would do "Lyrics text display" but I think that's too long. "Lyrics language" also won't work because
originalandromanizedare not languages.Also open to change the default. Default right now is
original, and I slightly prefer that.No English yet, as that would require the same or more manual work as this (which was decently long). I don't think it's feasible anyway because you can't really follow translated lyrics (if enhanced lyrics are gonna be a thing here, see mebtte/react-lrc#8).
WPE property to add: