Skip to content

⚡ Bolt: O(1) Station Name Lookup in TripsPage #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OsakaLOOP wants to merge 1 commit into
base: before-refractor
Choose a base branch
from
Open

⚡ Bolt: O(1) Station Name Lookup in TripsPage #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 19 additions & 9 deletions src/pages/TripsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,22 @@ export const TripsPage: React.FC = () => {
const addTrip = useStore(state => state.addTrip);
const { saveData } = useUserData();

const stationNameMap = useMemo(() => {
const map = new Map<string, string>();
for (const lineKey in railwayData) {
if (Object.prototype.hasOwnProperty.call(railwayData, lineKey)) {
const line = railwayData[lineKey];
if (line.stations) {
for (let i = 0; i < line.stations.length; i++) {
const st = line.stations[i];
map.set(st.id, st.name_ja);
}
}
}
}
return map;
}, [railwayData]);

const fileInputRef = useRef<HTMLInputElement>(null);

const handleImportSuica = async (event: React.ChangeEvent<HTMLInputElement>) => {
Expand Down Expand Up @@ -160,14 +176,8 @@ export const TripsPage: React.FC = () => {
const isWalk = t.isWalk;

if (isWalk) {
let startName = t.fromId || '';
let endName = t.toId || '';
Object.values(railwayData).forEach(line => {
const s = line.stations.find(st => st.id === t.fromId);
if (s) startName = s.name_ja;
const e = line.stations.find(st => st.id === t.toId);
if (e) endName = e.name_ja;
});
const startName = (t.fromId && stationNameMap.get(t.fromId)) || t.fromId || '';
const endName = (t.toId && stationNameMap.get(t.toId)) || t.toId || '';

const isTree = t.walkType === 'tree';
const cls = {
Expand Down Expand Up @@ -229,7 +239,7 @@ export const TripsPage: React.FC = () => {
{segments.map((seg, idx) => {
const line = railwayData[seg.lineKey];
const icon = line?.meta?.icon;
const getSt = (id: string) => line?.stations.find(s => s.id === id)?.name_ja || id;
const getSt = (id: string) => (id && stationNameMap.get(id)) || id;
return (
<div key={idx} className="relative z-10 flex flex-col text-sm">
<div className="flex items-center gap-2">
Expand Down