-
Notifications
You must be signed in to change notification settings - Fork 13
docs: remove redundant boolean attribute section #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: remove redundant boolean attribute section #82
Conversation
WalkthroughThe "Omit Boolean Attribute Value" section was removed from the HTML coding standards document. Its content was consolidated into the existing "Boolean Attributes" section, which was updated with additional examples to illustrate correct and incorrect usage of boolean attributes in HTML. Changes
Estimated code review effort1 (~2 minutes) Possibly related issues
Suggested labels
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <select> | ||
| <option value="1" selected="true">1</option> | ||
| </select> | ||
| <audio autoplay="autoplay" src="/audio/theme.mp3"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Include closing </audio> tag to stay aligned with the “Do Not Omit Closing Tags” rule
The examples add an <audio> element without its mandatory closing tag, which contradicts the guideline stated earlier in the same document (“Do Not Omit Closing Tags”, line 109).
Updating both “Bad” and “Good” snippets keeps the examples self-consistent and avoids signalling that <audio> is a void element (it is not).
-<audio autoplay="autoplay" src="/audio/theme.mp3">
+<audio autoplay="autoplay" src="/audio/theme.mp3"></audio>
…
-<audio autoplay src="/audio/theme.mp3">
+<audio autoplay src="/audio/theme.mp3"></audio>Also applies to: 204-204
🤖 Prompt for AI Agents
In coding-standards/html.md at lines 194 and 204, the <audio> elements are
missing their mandatory closing </audio> tags, which violates the "Do Not Omit
Closing Tags" guideline. Add the closing </audio> tags to both the "Bad" and
"Good" example snippets at these lines to ensure consistency and correct HTML
syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xixas perhaps we don't need to make this change. Let me know if this can be resolved without any changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!
Summary by CodeRabbit