Skip to content

Conversation

malvinpratama
Copy link

I am not good for documentation. But this PR is for support melos/microfrontend. So, we can set where the output file will generated. For now only support on android & ios

- Add support for custom_dir_path on melos
@OutdatedGuy
Copy link
Owner

Hi @malvinpratama thanks for the PR, I see you have added an additional key to specify custom directory path, but it seems to be not implemented for every function (in android and ios) i.e. Implemented for _setAndroidAppName and _setAndroidPackageName but not for _createNewMainActivity in android.

Also I was not able to run this implementation successfully on my side. Can you add some configuration details that I need to know?

P.S. Marking this PR as draft.

@OutdatedGuy OutdatedGuy marked this pull request as draft August 29, 2025 10:15
@malvinpratama
Copy link
Author

Hi @malvinpratama thanks for the PR, I see you have added an additional key to specify custom directory path, but it seems to be not implemented for every function (in android and ios) i.e. Implemented for _setAndroidAppName and _setAndroidPackageName but not for _createNewMainActivity in android.

Also I was not able to run this implementation successfully on my side. Can you add some configuration details that I need to know?

P.S. Marking this PR as draft.

@OutdatedGuy Sorry I forgot to commit that. Please check again

@OutdatedGuy
Copy link
Owner

Hi @malvinpratama, the errors are now gone, but I still need help setting up melos. Can you help me with that for testing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants