Skip to content

Fix duplicate camera VLAN issues for Wi-Fi Protect cameras#394

Merged
tvancott42 merged 1 commit intomainfrom
bugfix/camera-dedup
Mar 1, 2026
Merged

Fix duplicate camera VLAN issues for Wi-Fi Protect cameras#394
tvancott42 merged 1 commit intomainfrom
bugfix/camera-dedup

Conversation

@tvancott42
Copy link
Collaborator

@tvancott42 tvancott42 commented Mar 1, 2026

Summary

  • Fix duplicate audit issues for Wi-Fi connected Protect cameras - Cameras like the G6 Instant that connect via Wi-Fi were flagged twice: once by the Protect API fallback (Phase 3a) and again by the wireless client rule (Phase 3b). Fixed by running wireless client extraction before the fallback and adding all wireless client MACs to the skip set, so the wireless rule handles them with richer context (AP name, band, signal).
  • Two new dedup tests covering wireless camera skip and mixed wired/wireless scenarios.

Test plan

  • All 12 fallback tests pass (10 existing + 2 new)
  • Full suite passes (3,964 tests, 0 failures, 0 warnings)
  • Deploy to two test sites, run audit, verify single issue for Wi-Fi camera (not duplicate), and no regression on wired camera rule

Wi-Fi Protect cameras were flagged twice: once by the Phase 3a fallback
(Protect API) and again by Phase 3b (wireless client rules). Fix by
running wireless client extraction before the fallback and adding all
wireless client MACs to the fallback's skip set, so Phase 3b handles
them with richer context (AP name, band, signal).
@tvancott42 tvancott42 merged commit 85005ab into main Mar 1, 2026
1 check passed
@tvancott42 tvancott42 deleted the bugfix/camera-dedup branch March 1, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant