Merged
Conversation
…verrides (#401) * Skip hardware-disabled ports (enable: false) in audit rules Ports disabled at the hardware level via the UniFi enable flag were still being evaluated by UnusedPortRule and AccessPortVlanRule because only forward mode "disabled" was checked. This caused false positives on ports prepped for future use (e.g. SFP+ for upcoming GPON). * Revert AccessPortVlanRule skip - VLAN exposure should flag on disabled ports Hardware-disabled ports should still warn about excessive tagged VLANs since enabling the port later would immediately expose all VLANs. * Use ethernet_overrides to detect WAN ports on gateways The existing check only looked at network_name on the port, which can show "lan" even when the port is assigned to a WAN networkgroup via ethernet_overrides. Now also checks the device-level ethernet_overrides array to identify WAN-assigned interfaces (e.g. eth6 -> WAN4 for GPON).
* Fix notes textarea cursor jumping to end during save and sync notes across detail/table views * Use @Bind instead of value= to prevent cursor reset while allowing status indicator updates * Update Result.Notes before EventCallback so other instances sync immediately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v1.11.4 - ntfy.sh notifications, audit fix for staged WAN ports, notes cursor fix.