Merged
Conversation
Legacy (pre-zone-based) firewall rules have different field names than zone-based rules. Three fields were not being mapped: 1. Connection state booleans (state_new, state_established, state_related, state_invalid) - without these, an "Allow Established/Related" rule was treated as allowing all connection states including NEW, potentially eclipsing block rules below it. 2. Empty source/destination fields - a LAN_IN rule with no source or destination specified means "any" within that zone scope. Previously these rules matched nothing due to the fallback comparing empty string to network IDs. 3. protocol_match_excepted - the legacy equivalent of match_opposite_protocol.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
state_new/state_established/state_related/state_invalid),protocol_match_excepted, and proper ANY fallback for empty source/destination fields. Fixes false positive inter-VLAN isolation warnings for users with legacy "Allow Established/Related" rules above RFC1918 block rules.Test plan