Conversation
There was a problem hiding this comment.
Add these macOS specific files to .gitignore
| def _check_if_mutation_in_uorf(self) -> typing.Optional[str]: | ||
| variant_in_uorf = False | ||
| for uorf_region in self._canonical_uorf_coordinates_list: | ||
| if uorf_region.start <= self._variant_cdna_pos <= uorf_region.end: | ||
| variant_in_uorf = True | ||
| if variant_in_uorf == False: | ||
| return "Variant does not affect any canonical uORF" | ||
|
|
There was a problem hiding this comment.
Without understanding the details, I see no return statement in the case of variant_in_uorf = True
This means this method _check_if_mutation_in_uorf will return None, which has a truth value of False, unlike non empty string. This is correct, but maybe one could avoid the use of variant_in_uorf completely and do
for uorf_region in self._canonical_uorf_coordinates_list:
if uorf_region.start <= self._variant_cdna_pos <= uorf_region.end:
return None
return "Variant does not affect any canonical uORF"
There was a problem hiding this comment.
No idea if this is up to date, but I opened the repo looking for some methods to be used in promotizer and remembered I had promised a review.
Generally: looks good, nice! :)
I left some minor comments, we can discuss in January. Also, I did not look at the notebook, yet, I am only reviewing from the github webpage
2 participants
No description provided.