ERA-12684: Add event geometry, state, and segments methods#39
Open
JoshuaVulcan wants to merge 5 commits intomainfrom
Open
ERA-12684: Add event geometry, state, and segments methods#39JoshuaVulcan wants to merge 5 commits intomainfrom
JoshuaVulcan wants to merge 5 commits intomainfrom
Conversation
Implements event sub-resource endpoints for both ERClient and AsyncERClient:
- get_event_geometry(event_id): GET activity/event/{id}/geometry
- post_event_state(event_id, state): POST activity/event/{id}/state
- get_event_segments(event_id): GET activity/event/{id}/segments
Test coverage:
- Async tests using respx: success, not found, forbidden, bad request, timeout, empty results
- Sync tests using unittest.mock: success, not found, forbidden, empty results
ERA-12684
Co-authored-by: Cursor <cursoragent@cursor.com>
JoshuaVulcan
added
autoreviewing
# Conflicts: # tests/sync_client/conftest.py
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds three new event sub-resource methods (get_event_geometry, post_event_state, get_event_segments) to both the synchronous ERClient and AsyncERClient, along with comprehensive test coverage for both clients.
Changes:
- Added
get_event_geometry(),post_event_state(), andget_event_segments()methods to both sync and async client classes inerclient/client.py - Added test suite for the sync client covering success, not found, and forbidden scenarios
- Added test suite for the async client covering success, not found, forbidden, bad request, timeout, and null geometry edge cases
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| erclient/client.py | Adds 3 new event sub-resource methods to both ERClient and AsyncERClient |
| tests/sync_client/test_event_subresources.py | New test file for sync client event sub-resource methods |
| tests/async_client/test_event_subresources.py | New test file for async client event sub-resource methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| @@ -0,0 +1,156 @@ | |||
| import json | |||
| import pytest | ||
|
|
||
| from erclient import ( | ||
| ERClientException, |
| ) | ||
| response = await er_client.get_event_geometry(EVENT_ID) | ||
| assert route.called | ||
| # data is None, which is falsy -- should return the full json since data is falsy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_event_geometry(),post_event_state(), andget_event_segments()to bothERClient(sync) andAsyncERClient(async)Endpoints Covered
activity/event/{id}/geometryget_event_geometry(event_id)activity/event/{id}/statepost_event_state(event_id, state)activity/event/{id}/segmentsget_event_segments(event_id)Test Plan
pytest tests/ -v)Resolves ERA-12684