This repository was archived by the owner on May 27, 2022. It is now read-only.
Wal 123 common msg component removing all msgs#46
Open
MuffinLightning wants to merge 20 commits intodevelopfrom
Open
Wal 123 common msg component removing all msgs#46MuffinLightning wants to merge 20 commits intodevelopfrom
MuffinLightning wants to merge 20 commits intodevelopfrom
Conversation
- Fixed message count entering negative values
…/github.com/PBSA/peerplays-core-gui into WAL-123-Common-msg-component-removing-all-msgs
mseaward
changed the base branch from
develop
to
WAL-59-port-bookie-common-message-component
aametzler
previously approved these changes
Feb 14, 2019
mseaward
changed the base branch from
WAL-59-port-bookie-common-message-component
to
develop
mseaward
previously approved these changes
Feb 21, 2019
…ixed sidebar messaging
mseaward
suggested changes
Feb 26, 2019
mseaward
previously approved these changes
Mar 1, 2019
Modify classname assignment to support true BEM.
- modify some styling Remove Sidebar|Aside|Side messages
aametzler
suggested changes
Mar 5, 2019
| <p onClick={ () => props.clearMessage(id) }>X</p> | ||
| </span> | ||
| <div className='cmn-msg__cont'> | ||
| <span className='cmn-msg__cont-txt'>{pair.get('content') }</span> |
There was a problem hiding this comment.
if this is a modifier, shouldn't it be 'cmn-msg__cont--text'?
| </span> | ||
| <div className='cmn-msg__cont'> | ||
| <span className='cmn-msg__cont-txt'>{pair.get('content') }</span> | ||
| <p className='cmn-msg__cont-dismiss'onClick={ () => props.clearMessage(id) }>X</p> |
There was a problem hiding this comment.
if this is a modifier, shouldn't it be 'cmn-msg__cont--dismiss'?
| // Use lodash for a deep comparison of the merged messages. | ||
| if (!_.isEqual(propsMerged, prevPropsMerged)) { | ||
| this.checkToAssignTimer(propsMerged); | ||
| if (!_.isEqual(this.props.headerMessages, prevProps.headerMessages)) { |
There was a problem hiding this comment.
Common Message no longer displays under the header. Looks like something broke in this commit.
aametzler
previously approved these changes
Mar 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on WAL-59