Skip to content

CI/CD change#50

Merged
PCBZ merged 14 commits intomainfrom
CI/CD_Change
Apr 21, 2025
Merged

CI/CD change#50
PCBZ merged 14 commits intomainfrom
CI/CD_Change

Conversation

@PCBZ
Copy link
Copy Markdown
Owner

@PCBZ PCBZ commented Apr 21, 2025

No description provided.

@PCBZ PCBZ requested a review from Copilot April 21, 2025 17:24
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR titled "CI/CD change" updates the CI/CD workflow configurations while also making changes to donor management endpoints and cleaning up unused imports.

  • Removed unused icon import (FaCheckCircle) in event management.
  • Refactored donor retrieval and insertion logic in AllDonors and donorList endpoints.
  • Updated GitHub workflow files to restrict branch triggers and added a deploy step.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
client/src/components/events/EventManagement.jsx Removed unused FaCheckCircle icon from imports.
client/src/components/donors/AllDonors.jsx Updated donor component imports and adjusted state hooks accordingly.
Server/src/routes/donorList.js Modified donor endpoint to use donorIds, improved error handling, and consolidated update logic.
.github/workflows/docker-build.yml Restricted branch triggers to main.
.github/workflows/ci.yml Restricted branch triggers to main.
.github/workflows/cd.yml Restricted branch triggers to main and added a deployment step to Render.
Comments suppressed due to low confidence (2)

client/src/components/events/EventManagement.jsx:2

  • Verify that the removal of the FaCheckCircle import is intentional and that there are no remaining references to it in the component.
import { FaCalendarAlt, FaMapMarkerAlt, FaUsers, FaClock, FaTrash, FaFilter, FaSearch, FaEdit, FaEye } from 'react-icons/fa';

Server/src/routes/donorList.js:464

  • Duplicate update logic for donor list counts is observed in this endpoint; consider refactoring to a single update block to reduce redundancy and potential inconsistencies.
const updatedList = await prisma.eventDonorList.update({

@PCBZ PCBZ merged commit 351c9a5 into main Apr 21, 2025
2 checks passed
github-actions Bot pushed a commit that referenced this pull request Apr 21, 2025
@PCBZ PCBZ self-assigned this Apr 28, 2025
@PCBZ PCBZ added the good first issue Good for newcomers label Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants