Added Decision tree model #32 issue #108
Conversation
|
I will add the comments in cpp file soon till then, kindly check any other changes if required! |
|
Sir, this build error is not fixing, I don't know why, kindly look into it. |
|
@Sar-thak-3 pull fresh changes from main and remove the last line in cmake, it's possibly causing build failure |
|
Sir, checks were passed, kindly check is it okay? |
harshjohar
left a comment
harshjohar
left a comment
There was a problem hiding this comment.
Revert CMakeLists.txt file and do not change in future PRs
I revert the changes but there is an issue in "src/slowmokit/ducks/matrix/matrix.cpp" , which is creating an error in build. |
CMakeLists.txt
Outdated
|
|
||
| # base files | ||
| src/slowmokit/base.hpp | ||
| src/slowmokit/core.hpp | ||
| src/slowmokit/prereqs.hpp | ||
|
|
||
| # ducks | ||
| src/slowmokit/ducks/ducks.hpp | ||
| src/slowmokit/ducks/io/io.hpp | ||
| src/slowmokit/ducks/io/io.cpp | ||
| src/slowmokit/ducks/matrix/matrix.hpp | ||
|
|
||
| # methods | ||
| src/slowmokit/models/model.hpp | ||
| src/slowmokit/methods/neighbors/knn/knn.cpp | ||
| src/slowmokit/methods/neighbors/knn/knn.hpp | ||
| src/slowmokit/methods/linear_model/linear_regression.hpp | ||
| src/slowmokit/methods/linear_model/linear_regression/linear_regression.hpp | ||
| src/slowmokit/methods/linear_model/linear_regression/linear_regression.cpp |
There was a problem hiding this comment.
Remove all files added in cmake, and just keep the files till slowmokit.cpp
Sar-thak-3
force-pushed
the
decision_tree
branch
from
35860f2 to
eefc405
Compare
| add_library(slowmokit | ||
| src/slowmokit.hpp | ||
| src/slowmokit.cpp) |
There was a problem hiding this comment.
Vro all we need is this much, remove all the other files added
3 participants
No description provided.