-
Notifications
You must be signed in to change notification settings - Fork 7
pandas 3.0 compatibility #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -508,7 +508,7 @@ def test_flatten_timepoint_specific_output_overrides(): | |
| ) | ||
|
|
||
| pd.testing.assert_frame_equal( | ||
| problem.observable_df, observable_df_expected | ||
| problem.observable_df, observable_df_expected, check_dtype=False | ||
| ) | ||
|
Comment on lines
510
to
512
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because dataframe dtypes are a mess in petab.v1 :(. Not sure if discussing that there is really helpful. The actual data is still checked, that should be sufficient for this test.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ah, makes sense. I thought it was somehow an ironic consequence of the "improved" type checking in this PR. |
||
| pd.testing.assert_frame_equal( | ||
| problem.measurement_df, measurement_df_expected | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All edits in this file are in repeated code but fine as is