Newton assemble #180
Merged
Newton assemble #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of gmres polynomial
…n polynomial form of gmres polynomial
… done, just need to finish the higher order fixed sparsity terms in mat_mult_powers_share_sparsity_newton_cpu.
…r) cases are working, but the (r,c,c) is not yet.
…he three cases with real and complex eigenvalues, namely (r,r,r), (c,c,r) and (r,c,c) cases.
…ypes of GMRES polynomial
…n the rank deficient compute of harmonic ritz values lead to z negative eigenvalue (-1e-16). We now explicitly check for small eigenvalues in magnitude and set them to zero
…ES polynomials. Also ensure all the exact zero eigenvalues are moved to the end of the coefficients array.
…ES polynomial, both matrix-free and assembled
…s to test they can handle solving a problem where a lower order polynomial is an exact solution.
stevendargaville
force-pushed
the
newton_assemble
branch
from
59de76c to
10328e9
Compare
stevendargaville
force-pushed
the
newton_assemble
branch
from
ae7c03a to
994a051
Compare
…ison in ex12f_gmres_poly in parallel
…plementation (unconnected to the Newton form). If using higher-order fixed sparsity, the matching during the fixed sparsity matrix-matrix product was not correct for non-local columns of local rows
stevendargaville
force-pushed
the
newton_assemble
branch
from
eacdbcf to
85a3ab9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to compute assembled matrices for the Newton form of the GMRES polynomial inverses, with both fixed sparsity and without. Previously only a matrix-free form was allowed. Many new tests of this capability have also been added.
This PR also changes how the Harmonic Ritz values are computed, by both:
Also fixes an existing bug in the Kokkos GMRES polynomial implementation, unrelated to the Newton form.