-
Notifications
You must be signed in to change notification settings - Fork 6
DM-48642: Use private RNG rather than affecting global rng state #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This test failure seems unrelated to any of my changes since the action can't even install the dependencies. |
|
@PFLeget it's going to be hard for me to debug this if you need to approve the workflow every time I push. I've pushed some changes but if these don't work it may be better for you to modify the branch yourself. |
|
I just changed permission, it should now allow you to run test without me approving it. |
98e7767 to
2037520
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #27 +/- ##
==========================================
- Coverage 87.09% 86.96% -0.13%
==========================================
Files 8 8
Lines 767 775 +8
==========================================
+ Hits 668 674 +6
- Misses 99 101 +2 ☔ View full report in Codecov by Sentry. |
|
Ok. Looks like it passes now. Python 3.13 is broken but I'm not going to attempt to fix it: |
fitsio build was complaining it was missing
2037520 to
f92ef29
Compare
PFLeget
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.