Skip to content

Conversation

@timj
Copy link
Contributor

@timj timj commented Jan 28, 2025

No description provided.

@timj
Copy link
Contributor Author

timj commented Jan 29, 2025

This test failure seems unrelated to any of my changes since the action can't even install the dependencies.

configure: error: Unable to locate bz2 library needed when enabling bzip2 support; try specifying the path

@timj
Copy link
Contributor Author

timj commented Jan 29, 2025

@PFLeget it's going to be hard for me to debug this if you need to approve the workflow every time I push. I've pushed some changes but if these don't work it may be better for you to modify the branch yourself.

@PFLeget
Copy link
Owner

PFLeget commented Jan 29, 2025

I just changed permission, it should now allow you to run test without me approving it.

@timj timj force-pushed the tickets/DM-48642 branch from 98e7767 to 2037520 Compare January 29, 2025 17:25
@codecov
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.96%. Comparing base (624ac8b) to head (f92ef29).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #27      +/-   ##
==========================================
- Coverage   87.09%   86.96%   -0.13%     
==========================================
  Files           8        8              
  Lines         767      775       +8     
==========================================
+ Hits          668      674       +6     
- Misses         99      101       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@timj
Copy link
Contributor Author

timj commented Jan 29, 2025

Ok. Looks like it passes now. Python 3.13 is broken but I'm not going to attempt to fix it:

RuntimeError: Failed to evaluate kernel string 'RBF(0.45)'.  Original exception: name 'RBF' is not defined

timj added 2 commits January 29, 2025 10:30
@timj timj force-pushed the tickets/DM-48642 branch from 2037520 to f92ef29 Compare January 29, 2025 17:30
Copy link
Owner

@PFLeget PFLeget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PFLeget PFLeget merged commit eb4de3e into PFLeget:master Jan 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants