Pass --drop-private-types & --headers-dir to abidw #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The --headers-dir option tells abidw where to find the headers for it to consider. In abidw 2.8 and later, it implies --drop-private-types, thus evaluating only ABI changes in header files, not private ABI changes. Pass it explicitly in order to support earlier versions, as well. This change requires setting the options later in execution, so that `$installdir` is available to pass as part of the --headers-dir option. Only append the --drop-private-types option if it hasn't already been specified in the `abidw_flags_list` configuration, but always pass --headers-dir, since it can be specified multiple times, and we always want to include the Postgres headers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --headers-dir option tells abidw where to find the headers for it to consider. In abidw 2.8 and later, it implies --drop-private-types, thus evaluating only ABI changes in header files, not private ABI changes. Pass it explicitly in order to support earlier versions, as well.
This change requires setting the options later in execution, so that
$installdiris available to pass as part of the --headers-dir option.Only append the --drop-private-types option if it hasn't already been specified in the
abidw_flags_listconfiguration, but always pass --headers-dir, since it can be specified multiple times, and we always want to include the Postgres headers.