Conversation
📝 WalkthroughWalkthroughThe core package list managed by metapip now includes Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@R/zzz.R`:
- Line 18: Update the documentation that references the default branch to match
the code change: replace occurrences of the old default branch name ("DEV_v2")
with the new value ("PROD") in the README.Rmd paragraph that documents
metapip.default_branch so the README text reflects the current default set in
metapip.default_branch.
- Line 18: The project-wide default metapip.default_branch is set to "PROD" but
several packages (pipload, pipfun, pipdata, pipaux) do not have a PROD branch,
causing get_current_branches() and package_branches() to fail; fix by either
creating a PROD branch in each of those repos or changing metapip.default_branch
to a branch that all packages actually have (e.g., main/master) and update the
value in zzz.R (metapip.default_branch) so it matches the existing branch across
pipload, pipfun, pipdata, and pipaux; ensure no other code assumes PROD
elsewhere (search for get_current_branches and package_branches usage) and
adjust accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: c75fbcc9-ad34-45f5-b040-e4a7900b6e6b
📒 Files selected for processing (3)
R/attach.RR/zzz.RREADME.Rmd
|
|
||
| metapip_default_options <- list( | ||
| metapip.default_branch = "DEV_v2", | ||
| metapip.default_branch = "PROD", |
There was a problem hiding this comment.
Default-branch docs are stale after this change.
metapip.default_branch now defaults to "PROD", but README still says "DEV_v2" (README.Rmd Line 54 and the same paragraph). Please update that section to avoid misleading setup guidance.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@R/zzz.R` at line 18, Update the documentation that references the default
branch to match the code change: replace occurrences of the old default branch
name ("DEV_v2") with the new value ("PROD") in the README.Rmd paragraph that
documents metapip.default_branch so the README text reflects the current default
set in metapip.default_branch.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
org="PIP-Technical-Team"
# These inherit metapip.default_branch = "PROD" based on current overrides.
repos=(pipload pipfun pipdata pipaux)
for repo in "${repos[@]}"; do
if gh api "repos/${org}/${repo}/branches/PROD" --jq '.name' >/dev/null 2>&1; then
echo "OK: ${repo} has PROD"
else
echo "MISSING: ${repo} does not have PROD"
fi
doneRepository: PIP-Technical-Team/metapip
Length of output: 211
All packages that inherit metapip.default_branch = "PROD" lack a PROD branch.
Packages pipload, pipfun, pipdata, and pipaux do not have a PROD branch, which will cause runtime failures in get_current_branches() and package_branches(). Either create the PROD branch across all packages or change the default to a branch that exists on all of them.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@R/zzz.R` at line 18, The project-wide default metapip.default_branch is set
to "PROD" but several packages (pipload, pipfun, pipdata, pipaux) do not have a
PROD branch, causing get_current_branches() and package_branches() to fail; fix
by either creating a PROD branch in each of those repos or changing
metapip.default_branch to a branch that all packages actually have (e.g.,
main/master) and update the value in zzz.R (metapip.default_branch) so it
matches the existing branch across pipload, pipfun, pipdata, and pipaux; ensure
no other code assumes PROD elsewhere (search for get_current_branches and
package_branches usage) and adjust accordingly.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
README.md (1)
62-64: Clarify scope of the branch-behavior example.Line 62–64 can be misread as if the shown
options(...)call alone setswbpip,pipster,stamp, anddlw. Consider explicitly saying these come from package defaults unless overridden.Suggested doc tweak
-So in this case, the default value for `pipapi`, `wbpip` and `pipster` -branch is “DEV” whereas the one for `pipfaker`,`stamp` and `dlw` is set -to “main”. For rest of the pip core packages it remains as “PROD”. +With the package defaults, `pipapi`, `wbpip`, and `pipster` use “DEV”, +while `pipfaker`, `stamp`, and `dlw` use “main” (unless overridden in +`metapip.custom_branch`). The remaining core packages use “PROD”.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@README.md` around lines 62 - 64, Clarify that the example describes how branch defaults are determined: state explicitly that the shown options(...) call sets the default branch values for the named entries (pipapi, wbpip, pipster) to "DEV" and for pipfaker, stamp, dlw to "main", while all other pip core packages retain their "PROD" default from their individual package defaults unless those defaults are overridden; update the text to mention the options(...) call vs. package defaults and list the specific symbols (pipapi, wbpip, pipster, pipfaker, stamp, dlw, "DEV", "main", "PROD") so readers cannot misinterpret which values come from options(...) and which come from package defaults.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@README.md`:
- Around line 62-64: Clarify that the example describes how branch defaults are
determined: state explicitly that the shown options(...) call sets the default
branch values for the named entries (pipapi, wbpip, pipster) to "DEV" and for
pipfaker, stamp, dlw to "main", while all other pip core packages retain their
"PROD" default from their individual package defaults unless those defaults are
overridden; update the text to mention the options(...) call vs. package
defaults and list the specific symbols (pipapi, wbpip, pipster, pipfaker, stamp,
dlw, "DEV", "main", "PROD") so readers cannot misinterpret which values come
from options(...) and which come from package defaults.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5ecb4cc7-8f67-429a-afa0-7eef0e0481d9
📒 Files selected for processing (2)
README.RmdREADME.md
🚧 Files skipped from review as they are similar to previous changes (1)
- README.Rmd
|
Hola @randrescastaneda, never mind, I just realized it is a bit more complicated because the packages (stamp, dlw) are not part of the PIP-Technical-Team. I will try to work a bit more on it before asking you to approve the PR. |
1 participant
Hola @randrescastaneda,
I wanted to add stamp to the metapip packages, but I thought to add as well to add dlw. Also, since now we are using PROD as the main branch (Tefera already merged the last changes to this branch), then I made it the default branch. If you do not agree to any of these changes, I can change it accordingly. Thank you for reviewing.
Summary by CodeRabbit
New Features
Changes
Documentation