Closed
Conversation
added 5 commits
December 13, 2019 14:22
Used the tool `2to3` to convert code to Python 3 semi-automatically. A lot of iterators are needlessly converted to lists.
Contributor
|
Thanks for taking a swing at this, @Seanny123. I worked a bit on this over the holidays. The major issue is that I'm working on a minimum working fix in #35. It's slow going, but I'm making forward progress, little by little. |
Author
|
Old and obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my naive attempt to update the code to Python 3 using the
2to3tool. I was hoping the tool would do all the work and then running the basic example would magically work. Unfortunately, when I run:It gives an obscure error:
Other things which would help this code:
blackfor automatic code formattingpytestto run the tests