Skip to content

Conversation

@ab604
Copy link
Contributor

@ab604 ab604 commented Oct 22, 2025

User description

I ran into a dependancy issue when installing pridepy:

  • botocore dependency now requires Python >=3.9

I've updated lock file and toml to reflect the new constraint.


PR Type

Enhancement


Description

  • Update minimum Python version requirement from 3.7 to 3.9

  • Align with botocore dependency constraints

  • Remove support for EOL Python versions

  • Fix trailing newline in build configuration


Diagram Walkthrough

flowchart LR
  A["Python 3.7-3.8<br/>EOL versions"] -->|"Remove support"| B["Python 3.9+<br/>New minimum"]
  C["botocore<br/>dependency"] -->|"Requires"| B
  D["pyproject.toml"] -->|"Update constraint"| B
Loading

File Walkthrough

Relevant files
Dependencies
pyproject.toml
Update Python version constraint to 3.9                                   

pyproject.toml

  • Updated python dependency constraint from ^3.7 to ^3.9
  • Fixed trailing newline in build-backend configuration
  • Aligns with botocore's Python version requirements
+2/-2     

Summary by CodeRabbit

  • Chores
    • Updated minimum supported Python version requirement to 3.9.

- botocore dependency now requires Python >=3.9
- Python 3.7 and 3.8 are EOL
- Updated lock file to reflect new constraint
@qodo-code-review
Copy link
Contributor

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
🟢
No security concerns identified No security vulnerabilities detected by AI analysis. Human verification advised for critical code.
Ticket Compliance
🎫 No ticket provided
- [ ] Create ticket/issue <!-- /create_ticket --create_ticket=true -->

</details></td></tr>
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
No custom compliance provided

Follow the guide to enable custom compliance check.

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 22, 2025

Walkthrough

The minimum Python version requirement has been updated from 3.7 to 3.9 in the project configuration file, and a trailing newline has been added to fix the file ending.

Changes

Cohort / File(s) Summary
Python version constraint update
pyproject.toml
Updated [tool.poetry.dependencies] Python requirement from ^3.7 to ^3.9 and added trailing newline to fix file ending

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A hop, a skip, to Python three-point-nine,
We've left behind those ancient times of old,
With newlines neat and versions so divine,
The carrot patch grows richer, we are told! 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "Update Python version requirement to >=3.9" directly and accurately reflects the main change in the pull request. According to the raw summary, the primary modification updates the Python interpreter requirement from ^3.7 to ^3.9 in pyproject.toml, which aligns perfectly with the title. The PR objectives confirm this is the core intent of the change. The title is clear, specific, and concise without unnecessary noise or vague language. While the changeset also includes a minor fix for file ending (trailing newline), the title appropriately focuses on the primary change, which is consistent with the guideline that titles don't need to cover every detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8410afe and 4065898.

⛔ Files ignored due to path filters (1)
  • poetry.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (2 hunks)
🔇 Additional comments (2)
pyproject.toml (2)

47-47: Approve Python version requirement change.

The change from ^3.7 to ^3.9 correctly addresses the botocore dependency constraint and aligns with the existing tool configurations (black on line 76 and mypy on line 94, both already targeting Python 3.9).


109-109: Trailing newline fix looks good.

The addition of the trailing newline in the [build-system] section resolves the file-ending issue.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@qodo-code-review
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@ypriverol ypriverol requested a review from Copilot October 22, 2025 13:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the minimum Python version requirement from 3.7 to 3.9 to align with botocore dependency constraints, removing support for end-of-life Python versions.

  • Updated Python version constraint in pyproject.toml from ^3.7 to ^3.9
  • Ensures compatibility with botocore's Python >=3.9 requirement

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ypriverol ypriverol self-requested a review October 22, 2025 13:26
@ypriverol ypriverol merged commit e07a98a into PRIDE-Archive:master Oct 22, 2025
3 checks passed
@ypriverol
Copy link
Contributor

ypriverol commented Oct 22, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants