Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 8, 2025

The -skip option required explicitly passing true or false values, unlike other boolean flags in the CLI (e.g., --checksum_check).

Changes

  • Converted -skip/--skip_if_downloaded_already to --skip-if-downloaded-already/--no-skip-if-downloaded-already using Click's is_flag=True
  • Applied to all four download commands: download-all-public-raw-files, download-all-public-category-files, download-file-by-name, download-px-raw-files
  • Updated README documentation
  • Standardized help text across commands

Usage

Before:

pridepy download-all-public-raw-files -a PXD012353 -o /path/ -skip true

After:

# Default: skip existing files
pridepy download-all-public-raw-files -a PXD012353 -o /path/

# Force re-download
pridepy download-all-public-raw-files -a PXD012353 -o /path/ --no-skip-if-downloaded-already

Default behavior unchanged: files are skipped if already downloaded.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • proteomecentral.proteomexchange.org
    • Triggering command: /usr/bin/python3 python3 (dns block)
  • www.ebi.ac.uk
    • Triggering command: /usr/bin/python3 python3 -m pytest pridepy/tests/test_raw_files.py -v (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

On pridepy.py, Can you make this @click.option(
"-skip",
"--skip_if_downloaded_already",
required=False,
default=True,
help="Boolean value to skip the download if the file has already been downloaded.",
) a flag, currelty we have to pass true or false, every time we used it.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI self-assigned this Dec 8, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 8, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@ypriverol ypriverol marked this pull request as ready for review December 8, 2025 11:16
@qodo-code-review
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

Co-authored-by: ypriverol <52113+ypriverol@users.noreply.github.com>
Co-authored-by: ypriverol <52113+ypriverol@users.noreply.github.com>
Copilot AI changed the title [WIP] Update skip option to be a flag Convert skip_if_downloaded_already to a boolean flag Dec 8, 2025
Copilot AI requested a review from ypriverol December 8, 2025 11:27
@ypriverol ypriverol merged commit 9ba8085 into dev Dec 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants