Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 12, 2025

Per review feedback, simplified the dual flag --skip-if-downloaded-already/--no-skip-if-downloaded-already to a single boolean flag --skip-if-downloaded-already.

Changes

  • CLI flags: Converted dual flag to single flag format across all 4 download commands
  • Default behavior: Changed from skip-by-default (default=True) to download-by-default (default=False)
    • Without flag: files are re-downloaded even if they exist
    • With flag: existing files are skipped
  • Documentation: Updated README and docstrings to reflect new semantics

Example

# Before: Files skipped by default, use --no-skip-if-downloaded-already to force re-download
pridepy download-all-public-raw-files -a PXD001234 -o ./output

# After: Files re-downloaded by default, use flag to skip existing files
pridepy download-all-public-raw-files -a PXD001234 -o ./output --skip-if-downloaded-already

This makes the flag opt-in rather than opt-out, providing more explicit control over download behavior.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI mentioned this pull request Dec 12, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 12, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

@ypriverol ypriverol marked this pull request as ready for review December 12, 2025 11:59
@qodo-code-review
Copy link
Contributor

PR Code Suggestions ✨

No code suggestions found for the PR.

@ypriverol
Copy link
Contributor

@copilot --skip-if-downloaded-already must be a flag.

Copilot AI and others added 2 commits December 12, 2025 12:03
Co-authored-by: ypriverol <52113+ypriverol@users.noreply.github.com>
Co-authored-by: ypriverol <52113+ypriverol@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback by changing skip options to --skip-if-downloaded-already flag Convert --skip-if-downloaded-already to single flag format Dec 12, 2025
Copilot AI requested a review from ypriverol December 12, 2025 12:07
Copy link
Contributor Author

Copilot AI commented Dec 12, 2025

@copilot --skip-if-downloaded-already must be a flag.

The --skip-if-downloaded-already is already implemented as a flag with is_flag=True. Could you clarify what needs to be changed?

Current implementation:

@click.option(
    "--skip-if-downloaded-already",
    is_flag=True,
    default=False,
    help="Skip the download if the file has already been downloaded.",
)

CLI output shows it as a boolean flag:

--skip-if-downloaded-already    Skip the download if the file has already
                                been downloaded.

Are you concerned about the default behavior (currently False, meaning files are re-downloaded by default unless the flag is present)?

@ypriverol ypriverol merged commit 8842e9c into dev Dec 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants