Remove plotting capabilities of pridepy because they are not exposed on the commandline and not needed #80
Conversation
version bump 0.0.9 -> 0.0.10
The code was looking for 'aspera_tokenauth_id_rsa' but the actual key file is named 'asperaweb_id_dsa.openssh'. This caused authentication failures when downloading files via Aspera protocol. Fixes authentication prompt issue when using aspera protocol.
Fix Aspera key filename to match actual key file
improve skip options
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||
ypriverol
changed the title
PR Code Suggestions ✨No code suggestions found for the PR. |
The caret constraint (^5.18.0) was limiting plotly to <6.0.0, causing dependency conflicts for users who want to use plotly 6.x. The codebase only uses stable, basic plotly APIs (go.Bar and plotly.offline.plot) that are compatible with both plotly 5.x and 6.x. https://claude.ai/code/session_01VuwA6zF7mR9zPdgY2Fn8Nn
The statistics module was orphaned code that was never integrated into the CLI or exported from the package. Removing it eliminates the plotly dependency entirely, reducing install conflicts for users. Removed: - pridepy/statistics/ directory - plotly from pyproject.toml, requirements.txt, environment.yml, recipe/meta.yaml https://claude.ai/code/session_01VuwA6zF7mR9zPdgY2Fn8Nn
ypriverol
force-pushed
the
claude/fix-plotly-dependency-W3MX1
branch
from
6c9bf5e to
7b5d5ab
Compare
|
@sureshhewabi @selvaebi @chakrabandla do we use the plotting capabilities of pridepy? |
Summary
Removing plot capabilities of pridepy. Updated the plotly dependency constraint from a caret requirement (
^5.18.0) to a minimum version requirement (>=5.18.0), allowing installation of newer plotly versions while maintaining compatibility with 5.18.0 and above.Changes
pyproject.tomlto change plotly dependency from^5.18.0to>=5.18.0Details
This change relaxes the version constraint on plotly, which previously restricted installations to versions within the 5.18.x range (due to the caret operator). The new constraint allows any version 5.18.0 or higher, enabling users to benefit from plotly updates and bug fixes without waiting for a new release of this project.
This is a non-breaking change that improves dependency flexibility while maintaining a minimum version guarantee for compatibility.