Skip to content

fix: API Docs link breaks under ingress prefix without trailing slash #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ypriverol wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

fix: API Docs link breaks under ingress prefix without trailing slash #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion static/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,7 +886,7 @@ <h3>About SDRF Validator</h3>
</p>
<div class="about-links">
<a class="lnk-blue" href="https://github.com/bigbio/sdrf-pipelines" target="_blank">🌐 sdrf-pipelines</a>
<a class="lnk-green" href="docs" target="_blank">📂 API Docs</a>
<a class="lnk-green" id="api-docs-link" href="docs" target="_blank">📂 API Docs</a>
<a class="lnk-purple" href="https://www.ebi.ac.uk/pride/" target="_blank">📊 PRIDE Archive</a>
</div>
<div class="footer">
Expand Down Expand Up @@ -1037,6 +1037,14 @@ <h3>About SDRF Validator</h3>
const baseUrl = computeApiBase();
const apiUrl = (path) => baseUrl + String(path).replace(/^\/+/, '');

// Rewrite the docs link to an absolute URL anchored at the API base. The
// raw `href="docs"` resolves against window.location, which drops the last
// path segment when the page URL has no trailing slash — e.g. visiting
// /pride/services/sdrf-validator (no slash) would link to
// /pride/services/docs instead of /pride/services/sdrf-validator/docs.
const docsLink = document.getElementById('api-docs-link');
if (docsLink) docsLink.href = apiUrl('docs');

function showError(msg) {
errorBanner.textContent = msg;
errorBanner.classList.remove('hidden');
Expand Down
Loading