Less unboxing#18
Merged
MatejKocourek merged 8 commits intomainfrom Apr 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears to streamline execution and debugging around “less unboxing” by adjusting stencil return behavior/types, improving benchmark failure visibility, and standardizing test execution on Rscript instead of feeding scripts to R via stdin.
Changes:
- Switch test and benchmark Makefiles from
$(R) ... < file.R/-f ... --argsto$(RSCRIPT) --vanilla file.R .... - Update stencil function signatures/dispatch to return
Value(viaRET_T) and simplify theRETURNopcode implementation. - Improve diagnostics: print failing benchmark logs; add
rcp_print_stack_val_unbox()for GDB JIT stack inspection; adjust finalizers to not run on R shutdown.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| rcp/tests/types/Makefile | Run R tests via Rscript --vanilla |
| rcp/tests/smoketest/Makefile | Run smoketests via Rscript --vanilla |
| rcp/tests/exceptions/Makefile | Run exception test via Rscript --vanilla |
| rcp/tests/benchmarks/Makefile | Use Rscript to run benchmark compiler script |
| rcp/common.mk | Define RSCRIPT and use it for microbenchmark dependency check |
| rcp/inst/benchmarks/run-benchmarks.sh | Print per-benchmark log output on failure |
| rcp/src/stencils/stencils.c | Change stencil return type to Value and adjust RETURN |
| rcp/src/compile.c | Change finalizer on-exit behavior; add rcp_print_stack_val_unbox() |
| rcp/tests/gdb-jit/gdb-next/test.gdb | Use new unboxing stack printer in GDB script |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.