Skip to content

Less unboxing#18

Merged
MatejKocourek merged 8 commits intomainfrom
less-unboxing
Apr 22, 2026
Merged

Less unboxing#18
MatejKocourek merged 8 commits intomainfrom
less-unboxing

Conversation

@MatejKocourek
Copy link
Copy Markdown
Collaborator

No description provided.

@MatejKocourek MatejKocourek marked this pull request as ready for review April 7, 2026 13:11
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR appears to streamline execution and debugging around “less unboxing” by adjusting stencil return behavior/types, improving benchmark failure visibility, and standardizing test execution on Rscript instead of feeding scripts to R via stdin.

Changes:

  • Switch test and benchmark Makefiles from $(R) ... < file.R / -f ... --args to $(RSCRIPT) --vanilla file.R ....
  • Update stencil function signatures/dispatch to return Value (via RET_T) and simplify the RETURN opcode implementation.
  • Improve diagnostics: print failing benchmark logs; add rcp_print_stack_val_unbox() for GDB JIT stack inspection; adjust finalizers to not run on R shutdown.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
rcp/tests/types/Makefile Run R tests via Rscript --vanilla
rcp/tests/smoketest/Makefile Run smoketests via Rscript --vanilla
rcp/tests/exceptions/Makefile Run exception test via Rscript --vanilla
rcp/tests/benchmarks/Makefile Use Rscript to run benchmark compiler script
rcp/common.mk Define RSCRIPT and use it for microbenchmark dependency check
rcp/inst/benchmarks/run-benchmarks.sh Print per-benchmark log output on failure
rcp/src/stencils/stencils.c Change stencil return type to Value and adjust RETURN
rcp/src/compile.c Change finalizer on-exit behavior; add rcp_print_stack_val_unbox()
rcp/tests/gdb-jit/gdb-next/test.gdb Use new unboxing stack printer in GDB script

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread rcp/src/compile.c
@MatejKocourek MatejKocourek merged commit 5fd5aff into main Apr 22, 2026
12 checks passed
@MatejKocourek MatejKocourek deleted the less-unboxing branch April 22, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants