[CLOUD-254]: Custom profiles support for NodeTerminal #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescreep
requested changes
Dec 22, 2025
| nodeName, | ||
| substractHeight, | ||
| defaultProfile, | ||
| listPodTemplatesNs = 'incloud-web', |
Collaborator
There was a problem hiding this comment.
Seems like default option is not too good here
| plural: 'podtemplates', | ||
| namespace: listPodTemplatesNs, | ||
| }, | ||
| preserveStateOnUrlChange: false, |
| { | ||
| label: 'Predefined Profiles', | ||
| options: predefinedOptions, | ||
| }, |
Collaborator
There was a problem hiding this comment.
Better to remove predefined if we have specific pod templates. You will need an option to hide predifend options if you keep it
| ] | ||
| }, [hasPodTemplates, podTemplateNames]) | ||
|
|
||
| const isPredefinedProfile = PREDEFINED_PROFILES.includes(currentProfile as typeof PREDEFINED_PROFILES[number]) |
Collaborator
There was a problem hiding this comment.
Well currentProfile can be not that type. Better to remove as
| }, [hasPodTemplates, podTemplateNames]) | ||
|
|
||
| const isPredefinedProfile = PREDEFINED_PROFILES.includes(currentProfile as typeof PREDEFINED_PROFILES[number]) | ||
| const selectedPodTemplateName = hasPodTemplates && !isPredefinedProfile ? currentProfile : undefined |
Collaborator
There was a problem hiding this comment.
Profile names can be the same. So no need for this logic after removing show of dredefined if custom exist. Better just provide boolean to XTerminal
Collaborator
|
Add proper PR name please |
vsmeyukha
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://prorobotech.youtrack.cloud/issue/CLOUD-254/Factory-NodeTerminal-vozmozhnost-zadavat-kastomnyj-profil
Support of custom podTemplates in NodeTerminal