Add logout success handler with a service parameter#30
Open
tdb85 wants to merge 1 commit intoPRayno:masterfrom
Open
Add logout success handler with a service parameter#30tdb85 wants to merge 1 commit intoPRayno:masterfrom
tdb85 wants to merge 1 commit intoPRayno:masterfrom
Conversation
|
Hi, I don't know if this package is still maintained and no offense will be taken by the maintainer of it, but the service parameter in logout handler is handled in this package: https://github.com/ecphp/cas-bundle If this message is an issue, feel free to delete it as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our typical convention for our web applications is to have CAS logouts include a URL back to the application so they don't get stuck at the CAS logout screen.
This is particularly useful when you want to log out from one user and back in as another.
I've added a service which accepts route & parameters as additional parameters. This could perhaps be added to the existing LogoutSuccessHandler class, but I liked the idea of keeping that as a clean simple class when there are simple requirements.