Skip to content

Rearrange proportions pages, phase 3#562

Merged
statasaurus merged 64 commits intoPSIAIMS:mainfrom
petelaud:ratesci
Mar 24, 2026
Merged

Rearrange proportions pages, phase 3#562
statasaurus merged 64 commits intoPSIAIMS:mainfrom
petelaud:ratesci

Conversation

@petelaud
Copy link
Copy Markdown
Contributor

Further extensive updates for Issue #474 , this time mostly adding material on the single proportion and 2 independent proportions pages (SAS, R and comparison pages). Also made some related updates to the association/chi-squared pages. Paired proportions pages still to be updated.

In the process, I've been using the local Render facility, which seems to generate multiple files in a _freeze folder (unrelated to the files I was rendering). Please advise if this is expected.

There are some sections of text that I disagreed with, but rather than just delete I've commented out with with an explanation for the original contributor. This gets excluded from the rendered file on my local version.

petelaud added 30 commits March 10, 2026 17:25
…cOS) with the specified versions of flashClust, libcoin and rpact. Please advise. And I don't know why it resets the Python version to 3.11
…hy, table of methods produced by each package, added code examples for other packages, separate section for stratified Wilson, and many other updates
@statasaurus
Copy link
Copy Markdown
Contributor

Hello, Thank you for this. I started to do the review and noticed you use a function in your package that isn't on CRAN yet. Do you have an estimate of when you are going to push the updates to CRAN? I think we might need to add a note that rdci isn't on CRAN as of yet, unless it is going to CRAN imminently

@petelaud
Copy link
Copy Markdown
Contributor Author

Yes, I can add a note (In fact I already did that on the R/ci_for_prop page, but can add the same to R/ci_for_indep_prop). I keep finding things to add to the package as I'm working on the CAMIS pages, so I might wait until I've finished the paired proportions piece before pushing to CRAN, in case any more updates are needed.

It's turned into quite a big project - sorry if I've gone over the top in places, feel free to suggest if there are parts that could be left out (maybe don't need to cover so many packages?).

@statasaurus
Copy link
Copy Markdown
Contributor

Oh no it is totally fine. I know it is a big undertaking and you are doing great! I just trying to run stuff locally as I was reviewing and I ran into the issue, so I just imagine I won't be alone in that problem

@statasaurus statasaurus self-requested a review March 24, 2026 15:12
Copy link
Copy Markdown
Contributor

@statasaurus statasaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great thank you for this addition!

@statasaurus statasaurus merged commit e3c85e3 into PSIAIMS:main Mar 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants