Skip to content

Enhancement #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SauravBizbRolly wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Enhancement #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3c2135e
Bulk registration
SauravBizbRolly Mar 4, 2025
23cccac
Bulk registration
SauravBizbRolly Mar 11, 2025
83f693e
Bulk registration
SauravBizbRolly Mar 13, 2025
8ae4c09
Merge pull request #69 from toarunmishra/bulk_registration
sushant-bizbrolly Mar 13, 2025
cdd7b2a
add userName and password in Bulk registration
SauravBizbRolly Mar 31, 2025
128c8f9
add userName and password in Bulk registration
SauravBizbRolly Jun 19, 2025
a069382
Merge pull request #88 from toarunmishra/bulk_registration
SauravBizbRolly Jun 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
<org.mapstruct.version>1.2.0.Final</org.mapstruct.version>
<org.projectlombok.version>1.16.18</org.projectlombok.version>
<environment>${ENV_VAR}</environment>
<!-- <environment>test</environment>-->
<target-properties>target/classes/application.properties</target-properties>
<source-properties>target/classes/admin_${environment}.properties</source-properties>

Expand All @@ -54,6 +55,10 @@
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-devtools</artifactId>
</dependency>
<dependency>
<groupId>com.fasterxml.jackson.dataformat</groupId>
<artifactId>jackson-dataformat-xml</artifactId>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter</artifactId>
Expand All @@ -73,6 +78,11 @@
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-data-jpa</artifactId>
</dependency>
<dependency>
<groupId>org.apache.commons</groupId>
<artifactId>commons-compress</artifactId>
<version>1.21</version>
</dependency>
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-starter-web</artifactId>
Expand Down Expand Up @@ -181,12 +191,7 @@
<groupId>org.apache.poi</groupId>
<artifactId>poi-ooxml</artifactId>
<version>5.2.3</version>
<exclusions>
<exclusion>
<groupId>org.apache.commons</groupId>
<artifactId>commons-compress</artifactId>
</exclusion>
</exclusions>

</dependency>

<!-- start newly added dependencies -->
Expand Down
92 changes: 92 additions & 0 deletions src/main/java/com/iemr/admin/controller/bulkRegistration/BulkRegistrationController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,92 @@
package com.iemr.admin.controller.bulkRegistration;

import com.iemr.admin.repo.employeemaster.EmployeeMasterRepoo;
import com.iemr.admin.service.bulkRegistration.BulkRegistrationService;
import com.iemr.admin.service.bulkRegistration.BulkRegistrationServiceImpl;
import com.iemr.admin.service.bulkRegistration.EmployeeXmlService;
import com.iemr.admin.service.locationmaster.LocationMasterServiceInter;
import io.swagger.v3.oas.annotations.Operation;
import jakarta.servlet.http.HttpServletRequest;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.core.io.ClassPathResource;
import org.springframework.http.HttpHeaders;
import org.springframework.http.MediaType;
import org.springframework.http.ResponseEntity;
import org.springframework.web.bind.annotation.*;

import java.lang.reflect.Method;
import java.util.HashMap;
import java.util.Map;

@RestController
public class BulkRegistrationController {
@Autowired
private EmployeeXmlService employeeXmlService;
@Autowired
BulkRegistrationServiceImpl bulkRegistrationServiceimpl;
private Logger logger = LoggerFactory.getLogger(this.getClass().getSimpleName());


@Autowired
BulkRegistrationService bulkRegistrationService;

@Autowired
private EmployeeMasterRepoo employeeMasterRepoo;
private Map<String, Object> errorResponse = new HashMap<>();
@Autowired
private LocationMasterServiceInter locationMasterServiceInter;
private Map<String, Object> response = new HashMap<>();
Comment on lines +23 to +40
Copy link

@coderabbitai coderabbitai bot Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

❓ Verification inconclusive

Address dependency injection and security concerns.

Several issues with the controller structure:

  1. Inconsistent dependency injection: Both interface and implementation are autowired
  2. Security risk: @CrossOrigin() without restrictions allows all origins
  3. Missing rate limiting: Bulk operations should have rate limiting

Apply these changes:

-@RestController
+@RestController
+@RequestMapping("/api/v1")
 public class BulkRegistrationController {
-    @Autowired
-    private EmployeeXmlService employeeXmlService;
-    @Autowired
-    BulkRegistrationServiceImpl bulkRegistrationServiceimpl;
     private Logger logger = LoggerFactory.getLogger(this.getClass().getSimpleName());

     @Autowired
-    BulkRegistrationService bulkRegistrationService;
+    private BulkRegistrationService bulkRegistrationService;

-    @Autowired
-    private EmployeeMasterRepoo employeeMasterRepoo;
     private Map<String, Object> errorResponse = new HashMap<>();
-    @Autowired
-    private LocationMasterServiceInter locationMasterServiceInter;
     private Map<String, Object> response = new HashMap<>();

-    @CrossOrigin()
+    @CrossOrigin(origins = {"${app.allowed-origins}"}) // Configure in properties

Verify if rate limiting is implemented elsewhere:

🏁 Script executed:

#!/bin/bash
# Search for rate limiting configuration or annotations
rg -i "ratelimit|throttle|bucket" --type java

Length of output: 47

Address dependency injection and security concerns.

Several issues with the controller structure:

  1. Inconsistent dependency injection: Both interface and implementation are autowired
  2. Security risk: @CrossOrigin() without restrictions allows all origins
  3. Missing rate limiting: Bulk operations should have rate limiting

Apply these changes:

-@RestController
+@RestController
+@RequestMapping("/api/v1")
 public class BulkRegistrationController {
-    @Autowired
-    private EmployeeXmlService employeeXmlService;
-    @Autowired
-    BulkRegistrationServiceImpl bulkRegistrationServiceimpl;
     private Logger logger = LoggerFactory.getLogger(this.getClass().getSimpleName());

     @Autowired
-    BulkRegistrationService bulkRegistrationService;
+    private BulkRegistrationService bulkRegistrationService;

-    @Autowired
-    private EmployeeMasterRepoo employeeMasterRepoo;
     private Map<String, Object> errorResponse = new HashMap<>();
-    @Autowired
-    private LocationMasterServiceInter locationMasterServiceInter;
     private Map<String, Object> response = new HashMap<>();

-    @CrossOrigin()
+    @CrossOrigin(origins = {"${app.allowed-origins}"}) // Configure in properties

Verify if rate limiting is implemented elsewhere:

#!/bin/bash
# Search for rate limiting configuration or annotations
rg -i "ratelimit|throttle|bucket" --type java
🤖 Prompt for AI Agents 
In
src/main/java/com/iemr/admin/controller/bulkRegistration/BulkRegistrationController.java
between lines 23 and 40, fix the inconsistent dependency injection by autowiring
only the interface BulkRegistrationService and removing the direct injection of
its implementation BulkRegistrationServiceImpl. Add restrictive parameters to
the @CrossOrigin annotation to limit allowed origins instead of allowing all
origins. Implement rate limiting for bulk operations either by adding
appropriate annotations or middleware; first verify if rate limiting is already
configured elsewhere in the project by searching for related keywords like
"ratelimit", "throttle", or "bucket" in the Java codebase using the suggested
shell command. Apply the necessary changes based on the verification results.


@CrossOrigin()
@PostMapping(value = "/bulkRegistration", headers = "Authorization")
public ResponseEntity<Map<String, Object>> registerBulkUser(@RequestBody String m_user, @RequestHeader String authorization) {
bulkRegistrationServiceimpl.bulkRegistrationErrors.clear();
logger.info("Bulk registration request received. Request payload is omitted from logs.");
try {
bulkRegistrationService.registerBulkUser(m_user, authorization);
response.put("status", "Success");
response.put("statusCode", 200);
response.put("totalUser", bulkRegistrationServiceimpl.totalEmployeeListSize);
response.put("registeredUser", bulkRegistrationServiceimpl.m_bulkUser.size());
response.put("error", bulkRegistrationServiceimpl.errorLogs.toString());

bulkRegistrationServiceimpl.m_bulkUser.clear();
bulkRegistrationServiceimpl.m_UserDemographics.clear();
bulkRegistrationServiceimpl.errorLogs.clear();
bulkRegistrationServiceimpl.totalEmployeeListSize=0;

} catch (Exception e) {
response.put("message", e.getMessage());
response.put("statusCode", 500);

}
return ResponseEntity.ok(response);

}
Comment on lines +43 to +67
Copy link

@coderabbitai coderabbitai bot Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Improve error handling, input validation, and encapsulation.

Several issues need to be addressed:

  1. Poor encapsulation: Direct manipulation of service collections (bulkRegistrationServiceimpl.bulkRegistrationErrors.clear()) breaks encapsulation
  2. Generic exception handling: Catching all exceptions masks specific errors and makes debugging difficult
  3. Missing input validation: No validation of request body or authorization header
  4. Security concern: Logging omitted but sensitive data could be exposed in error responses

Apply this diff to improve the implementation:

 @PostMapping(value = "/bulkRegistration", headers = "Authorization")
 public ResponseEntity<Map<String, Object>> registerBulkUser(@RequestBody String m_user, @RequestHeader String authorization) {
-    bulkRegistrationServiceimpl.bulkRegistrationErrors.clear();
+    if (m_user == null || m_user.trim().isEmpty()) {
+        response.put("message", "Request body cannot be empty");
+        response.put("statusCode", 400);
+        return ResponseEntity.badRequest().body(response);
+    }
+    
     logger.info("Bulk registration request received. Request payload is omitted from logs.");
     try {
+        bulkRegistrationService.clearPreviousErrors(); // Add this method to service
         bulkRegistrationService.registerBulkUser(m_user, authorization);
         // ... rest of success logic
-    } catch (Exception e) {
+    } catch (IllegalArgumentException e) {
+        response.put("message", "Invalid input: " + e.getMessage());
+        response.put("statusCode", 400);
+        return ResponseEntity.badRequest().body(response);
+    } catch (Exception e) {
+        logger.error("Unexpected error during bulk registration", e);
         response.put("message", e.getMessage());
         response.put("statusCode", 500);
+        return ResponseEntity.status(500).body(response);
     }
-    return ResponseEntity.ok(response);
 }

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In
src/main/java/com/iemr/admin/controller/bulkRegistration/BulkRegistrationController.java
between lines 43 and 67, improve the method by removing direct access to service
internal collections and instead add appropriate service methods to clear or
retrieve data, replace the generic catch block with specific exception handling
to differentiate error types, add validation checks for the request body and
authorization header before processing, and avoid returning sensitive
information in error responses by logging errors internally but sending generic
error messages to clients.


@CrossOrigin()
@GetMapping("/download-error-sheet")
public ResponseEntity<byte[]> downloadErrorSheet() {
try {
byte[] fileContent = bulkRegistrationServiceimpl.insertErrorLog();

HttpHeaders headers = new HttpHeaders();
headers.add("Content-Disposition", "attachment; filename=error_log.xlsx");

if(!bulkRegistrationServiceimpl.bulkRegistrationErrors.isEmpty()){
bulkRegistrationServiceimpl.bulkRegistrationErrors.clear();
}
return ResponseEntity.ok()
.headers(headers)
.contentType(MediaType.APPLICATION_OCTET_STREAM)
.body(fileContent);

} catch (Exception e) {
return ResponseEntity.status(500).body(null);
}
}
Comment on lines +69 to +89
Copy link

@coderabbitai coderabbitai bot Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Improve error handling and security in error sheet download.

The endpoint has several issues:

  1. Generic exception handling: All exceptions return 500 with null body
  2. Potential data leakage: Error details might expose sensitive information
  3. Missing logging: No logging for debugging failures

Apply this diff:

 @GetMapping("/download-error-sheet")
 public ResponseEntity<byte[]> downloadErrorSheet() {
     try {
         byte[] fileContent = bulkRegistrationServiceimpl.insertErrorLog();
+        
+        if (fileContent == null || fileContent.length == 0) {
+            logger.warn("No error data available for download");
+            return ResponseEntity.noContent().build();
+        }

         HttpHeaders headers = new HttpHeaders();
         headers.add("Content-Disposition", "attachment; filename=error_log.xlsx");

-        if(!bulkRegistrationServiceimpl.bulkRegistrationErrors.isEmpty()){
-            bulkRegistrationServiceimpl.bulkRegistrationErrors.clear();
-        }
+        bulkRegistrationService.clearErrorsAfterDownload(); // Add this method to service
         
         return ResponseEntity.ok()
                 .headers(headers)
                 .contentType(MediaType.APPLICATION_OCTET_STREAM)
                 .body(fileContent);

     } catch (Exception e) {
+        logger.error("Error generating error sheet", e);
-        return ResponseEntity.status(500).body(null);
+        return ResponseEntity.status(500)
+                .body("Error generating error sheet".getBytes());
     }
 }

Committable suggestion skipped: line range outside the PR's diff.

🤖 Prompt for AI Agents 
In
src/main/java/com/iemr/admin/controller/bulkRegistration/BulkRegistrationController.java
between lines 69 and 89, improve error handling by catching specific exceptions
instead of a generic Exception, add logging of the exception details for
debugging, and sanitize or limit the error information included in the
downloadable file to prevent sensitive data exposure. Ensure the response on
failure returns a meaningful error message or status without exposing internal
details.



}
12 changes: 12 additions & 0 deletions src/main/java/com/iemr/admin/data/bulkuser/BulkRegistrationError.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package com.iemr.admin.data.bulkuser;

import lombok.Data;

import java.util.List;

@Data
public class BulkRegistrationError {
String userName;
Integer rowNumber;
List<String> error;
}
Comment on lines +7 to +12
Copy link

@coderabbitai coderabbitai bot Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add field validation and improve encapsulation.

The class fields lack validation and access control, which could lead to inconsistent data states.

+import jakarta.validation.constraints.NotNull;
+import jakarta.validation.constraints.Positive;
+import jakarta.validation.constraints.NotEmpty;

 @Data
 public class BulkRegistrationError {
+    @NotEmpty(message = "Username cannot be empty")
-    String userName;
+    private String userName;
+    
+    @NotNull(message = "Row number cannot be null")
+    @Positive(message = "Row number must be positive")
-    Integer rowNumber;
+    private Integer rowNumber;
+    
+    @NotNull(message = "Error list cannot be null")
-    List<String> error;
+    private List<String> errors;
 }

Also consider renaming error to errors for better clarity since it's a list.

🤖 Prompt for AI Agents 
In src/main/java/com/iemr/admin/data/bulkuser/BulkRegistrationError.java around
lines 7 to 12, the class fields lack access modifiers and validation, risking
inconsistent data. Add private access modifiers to all fields to improve
encapsulation. Implement validation logic in setters or constructors to ensure
userName is not null or empty, rowNumber is positive, and errors list is not
null or empty. Also, rename the field 'error' to 'errors' to better reflect that
it holds multiple error messages.

102 changes: 102 additions & 0 deletions src/main/java/com/iemr/admin/data/bulkuser/Employee.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,102 @@
package com.iemr.admin.data.bulkuser;

import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlProperty;
import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlRootElement;
import lombok.Data;

@Data
@JacksonXmlRootElement(localName = "Employee")
public class Employee {

@JacksonXmlProperty(localName = "Title")
private String title="";

@JacksonXmlProperty(localName = "FirstName")
private String firstName="";

@JacksonXmlProperty(localName = "MiddleName")
private String middleName="";

@JacksonXmlProperty(localName = "LastName")
private String lastName="";

@JacksonXmlProperty(localName = "Gender")
private String gender="";

@JacksonXmlProperty(localName = "ContactNo")
private String contactNo="";

@JacksonXmlProperty(localName = "Designation")
private String designation="";

@JacksonXmlProperty(localName = "EmergencyContactNo")
private String emergencyContactNo="";

@JacksonXmlProperty(localName = "DateOfBirth")
private String dob="";

@JacksonXmlProperty(localName = "Age")
private int age=0;

@JacksonXmlProperty(localName = "Email")
private String email="";

@JacksonXmlProperty(localName = "MaritalStatus")
private String maritalStatus="";

@JacksonXmlProperty(localName = "AadhaarNo")
private String aadhaarNo="";

@JacksonXmlProperty(localName = "PAN")
private String pan="";

@JacksonXmlProperty(localName = "Qualification")
private String qualification="";

@JacksonXmlProperty(localName = "FatherName")
private String fatherName="";

@JacksonXmlProperty(localName = "MotherName")
private String motherName="";

@JacksonXmlProperty(localName = "Community")
private String community="";

@JacksonXmlProperty(localName = "Religion")
private String religion="";

@JacksonXmlProperty(localName = "CurrentAddressLine1")
private String addressLine1="";

@JacksonXmlProperty(localName = "CurrentState")
private String state="";

@JacksonXmlProperty(localName = "CurrentDistrict")
private String district="";

@JacksonXmlProperty(localName = "CurrentPincode")
private String pincode="";

@JacksonXmlProperty(localName = "PermanentAddressLine1")
private String permanentAddressLine1="";

@JacksonXmlProperty(localName = "PermanentState")
private String permanentState="";

@JacksonXmlProperty(localName = "PermanentDistrict")
private String permanentDistrict="";

@JacksonXmlProperty(localName = "PermanentPincode")
private String permanentPincode="";

@JacksonXmlProperty(localName = "DateOfJoining")
private String dateOfJoining="";

@JacksonXmlProperty(localName = "UserName")
private String UserName="";

@JacksonXmlProperty(localName = "Password")
private String Password="";
Comment on lines +95 to +99
Copy link

@coderabbitai coderabbitai bot Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Fix field naming convention inconsistencies.

The fields UserName and Password don't follow Java camelCase naming convention, while other fields do. This inconsistency can lead to confusion and maintenance issues.

Apply this diff to fix the naming convention:

-    @JacksonXmlProperty(localName = "UserName")
-    private String UserName="";
+    @JacksonXmlProperty(localName = "UserName")
+    private String userName="";

-    @JacksonXmlProperty(localName = "Password")
-    private String Password="";
+    @JacksonXmlProperty(localName = "Password")
+    private String password="";
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
@JacksonXmlProperty(localName = "UserName")
private String UserName="";
@JacksonXmlProperty(localName = "Password")
private String Password="";
@JacksonXmlProperty(localName = "UserName")
private String userName="";
@JacksonXmlProperty(localName = "Password")
private String password="";
🤖 Prompt for AI Agents 
In src/main/java/com/iemr/admin/data/bulkuser/Employee.java around lines 95 to
99, the fields UserName and Password use PascalCase instead of the Java standard
camelCase. Rename these fields to userName and password respectively to maintain
consistent naming conventions across the class. Also update any references to
these fields accordingly to avoid compilation errors.



}
17 changes: 17 additions & 0 deletions src/main/java/com/iemr/admin/data/bulkuser/EmployeeList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
package com.iemr.admin.data.bulkuser;

import com.fasterxml.jackson.annotation.JsonProperty;
import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlElementWrapper;
import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlRootElement;
import lombok.Data;

import java.util.List;

@Data
@JacksonXmlRootElement(localName = "Employees")
public class EmployeeList {

@JsonProperty("Employee")
@JacksonXmlElementWrapper(useWrapping = false) // To avoid extra nested array in XML
private List<Employee> employees;
}
Comment on lines +10 to +17
Copy link

@coderabbitai coderabbitai bot Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Add validation and security considerations for XML processing.

The class lacks validation constraints and security considerations for XML processing, which could lead to XML injection or processing issues.

+import jakarta.validation.constraints.NotNull;
+import jakarta.validation.Valid;

 @Data
 @JacksonXmlRootElement(localName = "Employees")
 public class EmployeeList {

+    @NotNull(message = "Employee list cannot be null")
+    @Valid
     @JsonProperty("Employee")
     @JacksonXmlElementWrapper(useWrapping = false) // To avoid extra nested array in XML
     private List<Employee> employees;
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
@Data
@JacksonXmlRootElement(localName = "Employees")
public class EmployeeList {
@JsonProperty("Employee")
@JacksonXmlElementWrapper(useWrapping = false) // To avoid extra nested array in XML
private List<Employee> employees;
}
import jakarta.validation.constraints.NotNull;
import jakarta.validation.Valid;
@Data
@JacksonXmlRootElement(localName = "Employees")
public class EmployeeList {
@NotNull(message = "Employee list cannot be null")
@Valid
@JsonProperty("Employee")
@JacksonXmlElementWrapper(useWrapping = false) // To avoid extra nested array in XML
private List<Employee> employees;
}
🤖 Prompt for AI Agents 
In src/main/java/com/iemr/admin/data/bulkuser/EmployeeList.java around lines 10
to 17, add validation annotations to the employees list to ensure it is not null
or empty, such as @NotNull and @Size(min=1). Additionally, implement security
measures for XML processing by configuring the XML parser to prevent XML
External Entity (XXE) attacks and other vulnerabilities, ensuring safe
deserialization of XML data.

3 changes: 1 addition & 2 deletions src/main/java/com/iemr/admin/data/employeemaster/M_Religion.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@

@Entity
@Table(name = "m_Religion")
public class M_Religion
{
public class M_Religion {

@Id
@GeneratedValue(strategy = GenerationType.IDENTITY)
Expand Down
7 changes: 7 additions & 0 deletions src/main/java/com/iemr/admin/repo/employeemaster/EmployeeMasterRepoo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,16 @@ public interface EmployeeMasterRepoo extends CrudRepository<M_User1, Integer>
@Query("SELECT u FROM M_User1 u WHERE u.userID=:userID AND deleted=false")
M_User1 editEmployee(@Param("userID") Integer userID);

@Query("SELECT u FROM M_User1 u WHERE u.aadhaarNo=:aadhaar AND deleted=false ")
M_User1 findEmployeeAadhaarNo(@Param("aadhaar") String userName);
Comment on lines +43 to +44
Copy link

@coderabbitai coderabbitai bot Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix parameter naming inconsistency.

The parameter is named userName but should be aadhaar to match the query logic and improve code readability.

 @Query("SELECT u FROM M_User1 u WHERE u.aadhaarNo=:aadhaar AND deleted=false ")
-M_User1 findEmployeeAadhaarNo(@Param("aadhaar") String userName);
+M_User1 findEmployeeByAadhaar(@Param("aadhaar") String aadhaar);
🤖 Prompt for AI Agents 
In src/main/java/com/iemr/admin/repo/employeemaster/EmployeeMasterRepoo.java at
lines 43-44, the method parameter is named userName but should be renamed to
aadhaar to match the query parameter and improve clarity. Change the method
parameter name from userName to aadhaar so it aligns with the @Param("aadhaar")
annotation and the query logic.


@Query("SELECT u FROM M_User1 u WHERE u.userName=:userName AND deleted=false ")
M_User1 findEmployeeByName(@Param("userName") String userName);


@Query("SELECT u FROM M_User1 u WHERE u.contactNo=:contactNo AND deleted=false ")
M_User1 findEmployeeByContact(@Param("contactNo") String userName);
Comment on lines +50 to +51
Copy link

@coderabbitai coderabbitai bot Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix parameter naming inconsistency.

Similar to the Aadhaar method, the parameter should be named contactNo for consistency.

 @Query("SELECT u FROM M_User1 u WHERE u.contactNo=:contactNo AND deleted=false ")
-M_User1 findEmployeeByContact(@Param("contactNo") String userName);
+M_User1 findEmployeeByContact(@Param("contactNo") String contactNo);
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
@Query("SELECT u FROM M_User1 u WHERE u.contactNo=:contactNo AND deleted=false ")
M_User1 findEmployeeByContact(@Param("contactNo") String userName);
@Query("SELECT u FROM M_User1 u WHERE u.contactNo=:contactNo AND deleted=false ")
M_User1 findEmployeeByContact(@Param("contactNo") String contactNo);
🤖 Prompt for AI Agents 
In src/main/java/com/iemr/admin/repo/employeemaster/EmployeeMasterRepoo.java at
lines 50-51, the method parameter is named userName but should be contactNo to
match the query parameter and maintain consistency with similar methods. Rename
the method parameter from userName to contactNo to fix the inconsistency.


@Query("SELECT u FROM M_User1 u WHERE u.userName=:userName OR u.aadhaarNo=:aadhaarNo OR u.pAN=:getpAN OR u.employeeID=:employeeID OR u.healthProfessionalID=:healthProfessionalID AND deleted=false ")
M_User1 checkingEmpDetails(@Param("userName") String userName, @Param("aadhaarNo") String aadhaarNo,
@Param("getpAN") String getpAN,@Param("employeeID") String employeeID, @Param("healthProfessionalID") String healthProfessionalID);
Expand Down
5 changes: 5 additions & 0 deletions src/main/java/com/iemr/admin/service/bulkRegistration/BulkRegistrationService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
package com.iemr.admin.service.bulkRegistration;

public interface BulkRegistrationService {
void registerBulkUser(String user,String authorization);
}
Comment on lines +3 to +5
Copy link

@coderabbitai coderabbitai bot Jun 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Enhance the interface design for better error handling and feedback.

The current interface design has several limitations:

  1. Void return type provides no feedback about operation success/failure
  2. No exception declarations for proper error handling
  3. Parameter names could be more descriptive

Consider this improved design:

public interface BulkRegistrationService {
-    void registerBulkUser(String user,String authorization);
+    /**
+     * Registers users in bulk from XML data
+     * @param xmlData The XML data containing user information
+     * @param authorizationToken The authorization token for the request
+     * @return Registration result with success count and error details
+     * @throws BulkRegistrationException if processing fails
+     */
+    BulkRegistrationResult registerBulkUser(String xmlData, String authorizationToken) 
+            throws BulkRegistrationException;
}
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
public interface BulkRegistrationService {
void registerBulkUser(String user,String authorization);
}
public interface BulkRegistrationService {
/**
* Registers users in bulk from XML data
* @param xmlData The XML data containing user information
* @param authorizationToken The authorization token for the request
* @return Registration result with success count and error details
* @throws BulkRegistrationException if processing fails
*/
BulkRegistrationResult registerBulkUser(String xmlData, String authorizationToken)
throws BulkRegistrationException;
}
🤖 Prompt for AI Agents 
In
src/main/java/com/iemr/admin/service/bulkRegistration/BulkRegistrationService.java
around lines 3 to 5, the interface method registerBulkUser uses a void return
type and lacks exception declarations, providing no feedback on success or
failure and no error handling. Change the method to return a meaningful result
type indicating success or failure, declare appropriate exceptions to signal
errors, and rename parameters to more descriptive names like userName and
authToken for clarity.

Loading