fix(linting): fixed linting to now handle for XML and JAVA #73

Zapper9982 · 2025-04-25T15:15:03Z

📋 Description

JIRA ID:

Updated the linting to handle .java and .xml files

added Checkstyle.jar which allows linting for .java files
xmllint for linting xml files

✅ Type of Change

Screenshots

Summary by CodeRabbit

Chores
- Updated linting configuration to include checks for XML files.
- Adjusted file patterns for TypeScript and JavaScript linting.

coderabbitai · 2025-04-25T15:15:11Z

Walkthrough

The lint-staged configuration in package.json was updated to refine the file patterns and linting commands. The ESLint rule was adjusted to target only TypeScript and JavaScript files. A new linting command was added for XML files using xmllint --noout to validate XML syntax. Additionally, a formatting change was made by adding three leading spaces before the package declaration in ResourceRequestGateway.java. No changes were made to exported or public entities.

Changes

File(s)	Change Summary
package.json	Updated `lint-staged` configuration: modified ESLint file pattern to TS and JS only; added `xmllint` for XML files.
src/main/java/com/wipro/fhir/controller/...ResourceRequestGateway.java	Added three leading spaces before the package declaration (formatting only).

Poem

A hop and a skip, new linters arrive,
XML files now keep code alive.
ESLint narrows its careful gaze,
While xmllint joins the craze.
With every commit, our code’s more refined—
A garden of syntax, perfectly aligned!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bead703 and 3d3aa9e.

📒 Files selected for processing (1)

package.json (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

package.json

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Analyze (java)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

package.json (1)

15-17: Review the updated lint-staged file pattern.

The pattern src/**/*.{ts,js} now only includes .ts and .js files.

Have CSS and HTML files been intentionally removed from linting?

Should we also support .tsx and .jsx (and perhaps other extensions) to avoid unlinted code?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02e04d0 and dbba6ee.

⛔ Files ignored due to path filters (1)

checkstyle.jar is excluded by !**/*.jar

📒 Files selected for processing (1)

package.json (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Analyze (java)

🔇 Additional comments (2)

package.json (2)

18-20: Validate the Checkstyle command and placeholder syntax.

The entry
"*.java": [
  "java -jar checkstyle.jar -c checkstyle.xml {{files}}"
],
may not resolve {{files}} correctly under lint-staged. Lint-staged normally appends file paths automatically. Please confirm:

If you need explicit placeholders, use {} instead of {{files}}, or

Remove the placeholder and let lint-staged pass the paths by default.

Also verify that checkstyle.jar and checkstyle.xml are correctly located relative to the repo root.

21-23: Ensure correct xmllint invocation for XML files.

The command
"*.xml": [
  "xmllint --noout {{files}}"
]
uses {{files}}, which lint-staged may not recognize. You can rely on lint-staged to append file paths automatically by using:
"xmllint --noout"
Additionally, confirm that xmllint is installed on all target environments (local and CI).

drtechie · 2025-05-01T07:09:17Z

src/main/java/com/wipro/fhir/controller/generateresource/ResourceRequestGateway.java

 * along with this program.  If not, see https://www.gnu.org/licenses/.
 */
-package com.wipro.fhir.controller.generateresource;
+   package com.wipro.fhir.controller.generateresource;


@Zapper9982 what is this change about?

Oh! I was just checking if the linting was working Java files. I guess I forgot to uncommit that change , lemme fix it

drtechie · 2025-05-01T07:09:28Z

checkstyle.jar

@Zapper9982 let's not commit binary files.

sonarqubecloud · 2025-05-01T07:51:57Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

fix(linting): fixed linting to now handle for XML and JAVA

dbba6ee

coderabbitai bot reviewed Apr 25, 2025

View reviewed changes

Zapper9982 added 4 commits April 25, 2025 22:57

fix(linting): fix according to coderabbit

cb86a77

fix(lint): fix according to coderabbit

7092b06

fix(lint):Updated code according to coderabbit

2bdee6e

fix(lint): fixing compliance fail

bead703

drtechie reviewed May 1, 2025

View reviewed changes

checkstyle.jar Outdated

Copy link

Member

drtechie May 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zapper9982 let's not commit binary files.

Zapper9982 added 2 commits May 1, 2025 13:12

fix(rem): removed linting for java from package.json

3d3aa9e

style(check): uncommiting the space

ee6fc7a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(linting): fixed linting to now handle for XML and JAVA #73

fix(linting): fixed linting to now handle for XML and JAVA #73

Uh oh!

Zapper9982 commented Apr 25, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 25, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

drtechie May 1, 2025

Uh oh!

Zapper9982 May 1, 2025

Uh oh!

drtechie May 1, 2025

Uh oh!

sonarqubecloud bot commented May 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(linting): fixed linting to now handle for XML and JAVA #73

Are you sure you want to change the base?

fix(linting): fixed linting to now handle for XML and JAVA #73

Uh oh!

Conversation

Zapper9982 commented Apr 25, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📋 Description

✅ Type of Change

Screenshots

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

drtechie May 1, 2025

Choose a reason for hiding this comment

Uh oh!

Zapper9982 May 1, 2025

Choose a reason for hiding this comment

Uh oh!

drtechie May 1, 2025

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented May 1, 2025

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Zapper9982 commented Apr 25, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)