Skip to content

Conversation

@G4URAV001
Copy link

@G4URAV001 G4URAV001 commented May 4, 2025

📋 Description
fixes PSMRI/AMRIT#98
JIRA ID: issue98

This PR removes the unused lint-staged configuration and dependency from the project. The motivation for this change is that the lint-staged configuration targeted .ts, .css, and .html files in the src/ directory, but none of these file types exist in the project. Additionally, the Husky pre-commit hook that invoked lint-staged was deleted to prevent commit failures after the dependency was removed. No other configuration files (such as .factorypath) were affected, as they are unrelated to this tooling.

✅ Type of Change
[ ] 🐞 Bug fix
[ ] ✨ New feature
[ ] 🔥 Breaking change
[ ] 🛠 Refactor
[x] ⚙️ Config change (configuration file or build script updates)
[ ] 📚 Documentation
[ ] 🧪 Tests
[ ] 🎨 UI/UX
[ ] 🚀 Performance
[x] 🧹 Chore (miscellaneous changes that don't modify src or test files)
ℹ️ Additional Information
Removed the lint-staged section from package.json
Uninstalled the lint-staged npm package and removed it from devDependencies

npm uninstall lint-staged

Deleted the .husky/pre-commit hook, which was causing commit failures after lint-staged was removed
Confirmed that .factorypath and other project files were unaffected
Changes were tested by running git commit to ensure no pre-commit errors occur and by verifying that the project installs and runs as expected
No functional code was changed; these updates are purely configuration and maintenance related.
image

Summary by CodeRabbit

  • Chores
    • Removed automated linting of staged files during commits.
    • Removed related configuration and dependencies for lint-staged.

@G4URAV001
Copy link
Author

cc: @drtechie

@coderabbitai
Copy link
Contributor

coderabbitai bot commented May 4, 2025

Walkthrough

This change removes the lint-staged integration from the project. Specifically, it deletes the .husky/pre-commit file that invoked lint-staged as a pre-commit hook, eliminates the "lint-staged" configuration from package.json, and removes lint-staged from the list of development dependencies. A minor formatting update is also made to the "commit" script in package.json. No changes are made to exported or public entities.

Changes

File(s) Change Summary
.husky/pre-commit Deleted the pre-commit hook that ran npx lint-staged.
package.json Removed "lint-staged" configuration, deleted "lint-staged" from devDependencies, minor formatting.

Possibly related issues

Poem

A hop and a skip, the hooks are now gone,
No more lint-staged magic before a commit is done.
The package is lighter, the scripts are more neat,
With one less dependency, the code feels complete.
🐇✨

Goodbye, pre-commit—now onward we bound,
In the garden of code, where clean changes are found!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02e04d0 and 0082b50.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • .husky/pre-commit (0 hunks)
  • package.json (1 hunks)
💤 Files with no reviewable changes (1)
  • .husky/pre-commit
🔇 Additional comments (2)
package.json (2)

7-7: Minor formatting adjustment for commit script
The added space after the colon in "commit": "cz" is purely cosmetic and aligns with standard JSON styling.


19-19: Husky devDependency retained
Keeping "husky": "^9.1.7" is appropriate for managing other Git hooks (even though the pre-commit hook was removed). No version changes were made, so this remains compatible with your existing setup.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 4, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Unused lint-staged Configuration for Non-Existing ts and css Files

1 participant