Fix reference architecture AWS EKS example #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomassurin
commented
Sep 24, 2025
| version = "~> 6.0" | ||
|
|
||
| role_name = "${var.cluster_name}-AmazonEKS-LoadBalancerController-Role" | ||
| name = "${var.cluster_name}-ALB-Role" |
There was a problem hiding this comment.
Previous names were too long (must be < 32 characters)
tomassurin
commented
Sep 24, 2025
| namespace_name = "nutrient-document-engine" | ||
| helm_release_name = "document-engine" | ||
| helm_chart_version = "" # get the latest | ||
| helm_chart_version = "5.4.0" |
There was a problem hiding this comment.
Does not work without explicit version.
There was a problem hiding this comment.
Strange.
Explicit version is not bad per se, but it should work without.
|
I want to carefully walk through it — please allow me some time to actually run it and see what where how. |
|
I want to carefully walk through it — please allow me some time to actually run it and see what where how. I am testing the Auto KMS thing at the moment - moving to EKS auto managed node pools and annotations to specify instance type to run DE on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependencies updates, making sure it actually works.