fix(publish): add Pydantic models for template nested structures #34
Conversation
Add ChangelogEntry and SupportLink Pydantic models to properly type the nested structures in VersionInfo and SupportInfo. This fixes the Jinja2 template error where dict objects don't have expected attributes. - Add ChangelogEntry model with version, date, description fields - Add SupportLink model with label, url fields - Update VersionInfo.changelog to use list[ChangelogEntry] - Update SupportInfo.links to use list[SupportLink] - Export new models from agents/__init__.py Closes #33 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary of ChangesHello @PSthelyBlog, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the data structures used for publishing information by introducing dedicated Pydantic models for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the data models for changelog entries and support links to use dedicated Pydantic models (ChangelogEntry and SupportLink) instead of generic dictionaries. This is a great improvement for type safety and code clarity. The changes are well-implemented. I've added a couple of suggestions to further enhance data validation by using more specific Pydantic and standard library types for dates and URLs. Overall, this is a solid contribution.
| """A changelog entry for version history.""" | ||
|
|
||
| version: str = Field(..., description="Version number (e.g., '1.0.0')") | ||
| date: str = Field(..., description="Release date (e.g., '2026-01-20')") |
There was a problem hiding this comment.
For improved type safety and automatic validation, consider changing the type of date from str to datetime.date. Pydantic can automatically parse date strings in 'YYYY-MM-DD' format into date objects. This would require adding from datetime import date at the top of the file.
| """A support link entry.""" | ||
|
|
||
| label: str = Field(..., description="Link label (e.g., 'Bug Reports')") | ||
| url: str = Field(..., description="Link URL") |
There was a problem hiding this comment.
For robust URL validation, consider using one of Pydantic's URL types, like AnyUrl or HttpUrl, instead of str. This will automatically validate that the provided string is a valid URL. You would need to import it from pydantic, for example: from pydantic import AnyUrl.
Refs #33 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Summary
ChangelogEntryPydantic model withversion,date,descriptionfieldsSupportLinkPydantic model withlabel,urlfieldsVersionInfo.changelogto uselist[ChangelogEntry]instead oflist[dict[str, str]]SupportInfo.linksto uselist[SupportLink]instead oflist[dict[str, str]]agents/__init__.pyTest plan
Closes #33
🤖 Generated with Claude Code