Fix the bug of block attention residuals in AMP#719
Open
pkuzyc wants to merge 1 commit intoPaddlePaddle:developfrom
Open
Fix the bug of block attention residuals in AMP#719pkuzyc wants to merge 1 commit intoPaddlePaddle:developfrom
pkuzyc wants to merge 1 commit intoPaddlePaddle:developfrom
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #719 +/- ##
=========================================
Coverage ? 0.00%
=========================================
Files ? 2
Lines ? 4
Branches ? 2
=========================================
Hits ? 0
Misses ? 2
Partials ? 2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the bug of block attention residuals in AMP. When embedding output is float32 and pushed into the block list, block attention residuals will get a float32-type output, causing a type mismatch error in LinearWithGradAccumulationAndAsyncCommunication backward function.