Skip to content

Conversation

@Manfredss
Copy link
Contributor

Sink asinh, atan to cpp, add param decorator to atan2

Copilot AI review requested due to automatic review settings December 12, 2025 23:21
@paddle-bot
Copy link

paddle-bot bot commented Dec 12, 2025

感谢你贡献飞桨文档,文档预览构建中,Docs-New 跑完后即可预览,预览链接:http://preview-pr-7668.paddle-docs-preview.paddlepaddle.org.cn/documentation/docs/zh/api/index_cn.html
预览工具的更多说明,请参考:飞桨文档预览工具

@github-actions
Copy link

github-actions bot commented Dec 12, 2025

📚 本次 PR 文档预览链接(点击展开)
ℹ️ 预览提醒
请等待 Docs-NEW 流水线运行完成后再点击预览链接,否则可能会看到旧版本内容或遇到链接无法访问的情况。

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds API compatibility by introducing an optional out parameter to three mathematical functions (asinh, atan, and atan2) in their Chinese documentation. The out parameter is added as a keyword-only argument with a default value of None.

Key Changes:

  • Added out parameter to function signatures of asinh, atan, and atan2
  • Updated parameter documentation sections to describe the new out parameter
  • Modified data type descriptions for asinh to include additional types (float16, bfloat16)

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
docs/api/paddle/atan_cn.rst Added out parameter to function signature and parameter documentation
docs/api/paddle/atan2_cn.rst Added out parameter to function signature and parameter documentation
docs/api/paddle/asinh_cn.rst Added out parameter and updated data type list (incomplete)
docs/api/paddle/asin_cn.rst Contains unresolved merge conflict markers from another change

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

参数
:::::::::
- **x** (Tensor) - 输入的 Tensor,数据类型为:float32float64、complex64、complex128。
- **x** (Tensor) - 输入的 Tensor,数据类型为: float32, float64, float16, bfloat16,
Copy link

Copilot AI Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter description for x is incomplete. The line ends with a comma and the list of data types is not finished. This should include the complete list of supported data types.

Suggested change
- **x** (Tensor) - 输入的 Tensor,数据类型为: float32, float64, float16, bfloat16,
- **x** (Tensor) - 输入的 Tensor,数据类型为:float32float64float16bfloat16、complex64、complex128。

Copilot uses AI. Check for mistakes.
@Manfredss Manfredss changed the title [API Compatibility] Sink asinh, atan to cpp, add param decorator to atan2 [API Compatibility No.31-33] Sink asinh, atan to cpp, add param decorator to atan2 Dec 12, 2025
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor HappyOpenSource 快乐开源活动issue与PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants