Skip to content
This repository was archived by the owner on Jan 10, 2020. It is now read-only.

Conversation

@shortdudey123
Copy link
Contributor

  • Add support for encrypted data bags
  • Add support for unencrypted data bags
  • Add support for accessID and accessKey usage
  • Update doc to reflect correct attributes
  • Make old email and password attributes consistent w/ sumologic collector cookbook
  • Add test kitchen testing around data bag support

@shortdudey123
Copy link
Contributor Author

hmmm
Tests pass locally but Travis is correct since the method has 42 lines and not 38 or less as configured in .rubocop_todo.yml... and rubocop is the same version

hostname:~/chef-sumologic username (support_ecrypted_data_bags)$ bundle exec rubocop libraries/sumo_source_provider.rb
Inspecting 1 file
.

1 file inspected, no offenses detected
hostname:~/chef-sumologic username (support_ecrypted_data_bags)$ 

@shortdudey123
Copy link
Contributor Author

@ranjib can you review this one last time and merge when you have a chance?

@gswallow
Copy link

Could you use strings, instead of symbols, to access node attributes in your change?

@shortdudey123
Copy link
Contributor Author

@gswallow you should be able to yes

@gswallow
Copy link

No, I mean, this pull request doesn't work for me. I had to change L127-136 of sumo_source_provider.rb to use strings, rather than symbols, when loading an encrypted data bag.

@shortdudey123
Copy link
Contributor Author

Ah gotcha

@ranjib can you update this please :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants