-
Notifications
You must be signed in to change notification settings - Fork 28
Fixed slack link #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed slack link #121
Conversation
Our Pull Request Approval ProcessThis PR will be reviewed according to our: Your PR may be automatically closed if:
Thanks for contributing! |
WalkthroughUpdated the footer's Community section in the Docusaurus configuration, changing the label from "Slack" to "Forums", the link destination from GitHub to the community forum at https://community.talawa.io/, and the corresponding CSS class from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
docusaurus.config.ts(1 hunks)
🔇 Additional comments (1)
docusaurus.config.ts (1)
130-130: Verify the URL and note trailing slash inconsistency.The navbar links to the same forum at line 100 but without a trailing slash (
https://community.talawa.io), while this footer link includes one. Consider standardizing for consistency.Run the following script to verify the URL is accessible:
#!/bin/bash # Description: Verify the community forum URL is accessible # Test the URL with and without trailing slash echo "Testing URL with trailing slash:" curl -s -o /dev/null -w "HTTP Status: %{http_code}\n" https://community.talawa.io/ echo "Testing URL without trailing slash:" curl -s -o /dev/null -w "HTTP Status: %{http_code}\n" https://community.talawa.io
| label: ' Slack', | ||
| to: 'https://github.com/PalisadoesFoundation', | ||
| className: 'footer__icon footer__slack', | ||
| label: 'Forums', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add leading space to the label for consistency.
All other footer link labels in this configuration include a leading space (lines 134, 139, 149, 154, 159, 169), but "Forums" is missing one.
Apply this diff to maintain consistency:
- label: 'Forums',
+ label: ' Forums',📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| label: 'Forums', | |
| label: ' Forums', |
🤖 Prompt for AI Agents
docusaurus.config.ts around line 129: the footer link label "Forums" lacks the
leading space used by other labels; update the label value from 'Forums' to '
Forums' so it matches the formatting of the other footer link labels for
consistency.
| className: 'footer__icon footer__slack', | ||
| label: 'Forums', | ||
| to: 'https://community.talawa.io/', | ||
| className: 'footer__icon footer__news', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial
Consider using a more semantic CSS class name.
The footer__news class is already used for the "News" link (line 136). While this may work functionally, using a distinct class like footer__forums or footer__forum would be more semantic and maintainable.
Apply this diff if you want more semantic styling:
- className: 'footer__icon footer__news',
+ className: 'footer__icon footer__forums',📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| className: 'footer__icon footer__news', | |
| className: 'footer__icon footer__forums', |
🤖 Prompt for AI Agents
In docusaurus.config.ts around line 131, the social link uses className:
'footer__icon footer__news' which reuses the News class; change it to a
distinct, semantic class such as 'footer__icon footer__forums' (or
'footer__forum') and update any related CSS/Sass to define styling for the new
class so the Forums icon has its own semantic selector.
Fixed slack link
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.