DF/data4es/093: refactoring. #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Extracting a specific field from a dataset name is a single logical operation -- so it is much more readable to have a function call "give me data format" then the whole algorithm's implementation within a more high-level operation (in this case, getting a list of formats that should be associated to the dataset). 2. Dataset name parsing doesn't look like a stage-specific functionality, more like a whole use-case specific one. So it is moved to the (new) case-specific module of the common library.
1 task
Evildoor
approved these changes
Jul 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting a specific field from a dataset name is a single logical
operation -- so it is much more readable to have a function call "give
me data format" then the whole algorithm's implementation within a more
high-level operation (in this case, getting a list of formats that
should be associated to the dataset).
Dataset name parsing doesn't look like a stage-specific functionality,
more like a whole use-case specific one. So it is moved to the (new)
case-specific module of the common library.
(Partly) overrides #371