Skip to content

Conversation

@hyperrealist
Copy link
Contributor

@hyperrealist hyperrealist commented Dec 4, 2025

Fixes #106

MyPy complains about variadic tuples of generics in overloads, but I believe that is a mypy quirk.

@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.47%. Comparing base (4a90ca6) to head (31cb1eb).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   97.45%   97.47%   +0.01%     
==========================================
  Files          12       12              
  Lines        1219     1226       +7     
==========================================
+ Hits         1188     1195       +7     
  Misses         31       31              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hyperrealist hyperrealist requested a review from coretl December 4, 2025 17:14
Copy link
Contributor

@coretl coretl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hyperrealist hyperrealist merged commit fd780d5 into PandABlocks:main Dec 5, 2025
13 checks passed
@hyperrealist hyperrealist deleted the 106-pandablocks-client-pass-server-version-to-command.execute branch December 5, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pass server version from Identify down to Command.execute

2 participants