Skip to content

Conversation

@onurv13
Copy link
Contributor

@onurv13 onurv13 commented Sep 30, 2014

No description provided.

@lukasappelhans
Copy link
Member

I think we should show a dialog instead of directly deleting the user. Obviously this is an action that cannot be undone that quickly.

@lukasappelhans
Copy link
Member

Please respect the comment, then we should merge it? :)

@nafergo
Copy link

nafergo commented Oct 28, 2014

imho "destructive" action should have something like a "are you sure?" dialog. agree with boom1992

@lukasappelhans
Copy link
Member

Onur, look into Bootstrap Modals, it should be relatively easy. (Just show the dialog from the html, the "Yes I'm sure" will trigger the actual function.)

Nelson, nice to see you doing code reviews as well! :) we'll try to keep this going, even though at least my time is very limited these days. Did you test it yet? Found any bugs?

@onurv13
Copy link
Contributor Author

onurv13 commented Oct 28, 2014

Don't take my silence as ignorance. I was working on it just today but before I could test it our server went down. I am going to upload it as soon as possible. I am getting 404 at the moment :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants