fix(tax_validation): tax id validation based on vat registraton such as turnover#571
Open
kunhimohamed wants to merge 1 commit intoParaLogicTech:version-15from
Open
fix(tax_validation): tax id validation based on vat registraton such as turnover#571kunhimohamed wants to merge 1 commit intoParaLogicTech:version-15from
kunhimohamed wants to merge 1 commit intoParaLogicTech:version-15from
Conversation
SaiFi0102
requested changes
Apr 27, 2026
| if validation == "Mandatory for Company and Annual Turnover": | ||
| if frappe.get_cached_value("Customer", self.bill_to or self.customer, "customer_type") == "Individual" or \ | ||
| (frappe.get_cached_value("Customer", self.bill_to or self.customer, "customer_type") == "Company" and \ | ||
| frappe.get_cached_value("Customer", self.bill_to or self.customer, "vat_registration_decider") == "Annual Turnover <= 375,000 AED"): |
Member
There was a problem hiding this comment.
Cannot add into core because vat_registration_decider is not a core field
Author
There was a problem hiding this comment.
Is we need to override the method by custom application?
Member
There was a problem hiding this comment.
I'd recommend a hidden checkbox in Customer master for the core something like "Tax ID Non Mandatory" tax_id_non_mandatory, this checkbox will be 0 by default, and 1 only if vat_registration_decider meets the criteria. The core will only check tax_id_non_mandatory to override the validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.